Remove additional header borders from Sync preferences

RESOLVED FIXED in Firefox 46

Status

()

P1
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: rfeeley, Assigned: sakshivaid95, Mentored)

Tracking

unspecified
Firefox 46
Points:
---
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox46 fixed)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
In-content preferences have a border underneath the header, but there is a border above and below the device section that should be removed.
Flags: firefox-backlog+
Priority: -- → P1
Mentor: markh
Whiteboard: [good first bug]

Comment 1

3 years ago
Hello I would like to work on this bug, could you please guide me through?
(In reply to chaithanya from comment #1)
> Hello I would like to work on this bug, could you please guide me through?

Please see comment 0 - this is talking about the page displayed for about:preferences#sync when a user is signed in to Sync, and discusses a border that should be removed.
(Assignee)

Comment 3

3 years ago
I would like to take up the bug, if is not being assigned to anyone.
(Assignee)

Comment 4

3 years ago
Hello. Here is proposed patch. It removes the headers as per the given description. Please review.
Attachment #8709963 - Flags: review?(markh)
A patch from the contributor, so assigning the bug to her.
Assignee: nobody → sakshivaid95
Comment on attachment 8709963 [details] [diff] [review]
Remove additional header borders from Sync preferences

Review of attachment 8709963 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks.
Attachment #8709963 - Flags: review?(markh) → review+
Keywords: checkin-needed

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8eebf2798ebf
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46

Comment 9

3 years ago
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name 			Firefox
Version 		46.0b4
Build ID 		20160322075646
Update Channel 	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS                      Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
You need to log in before you can comment on or make changes to this bug.