Closed Bug 1207191 Opened 6 years ago Closed 6 years ago

Remove or delay redundant JS(M) imports in WebcompatReporter

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: esawin, Assigned: esawin)

References

Details

Attachments

(1 file, 2 obsolete files)

Importing JS(M) modules has a great impact on startup performance on Android, so we should not import modules pre-maturely and delay importing where possible.
Assignee: nobody → esawin
Status: NEW → ASSIGNED
I don't see these modules being used there and importing JNI.jsm early during startup has a negative effect on performance (bug 1202697) on Nightly.
Attachment #8664265 - Flags: review?(s.kaspari)
Blocks: 1202697
OS: Unspecified → Android
Hardware: Unspecified → All
Attachment #8664265 - Flags: review?(s.kaspari) → review+
Sorry, I've missed to merge this part. We can delay importing this module until the first call to reportIssue.
Attachment #8664384 - Flags: review?(s.kaspari)
Comment on attachment 8664384 [details] [diff] [review]
0001-Bug-1207191-Delay-imports-in-WebcompatReporter.js.-r.patch

WebcompatReporter.js is only used in Nightly builds btw. :)
Attachment #8664384 - Flags: review?(s.kaspari) → review+
(In reply to Sebastian Kaspari (:sebastian) from comment #3)
> Comment on attachment 8664384 [details] [diff] [review]
> 0001-Bug-1207191-Delay-imports-in-WebcompatReporter.js.-r.patch
> 
> WebcompatReporter.js is only used in Nightly builds btw. :)

I'm aware of that, but I would prefer to keep Nightly-only features tidy, too, for the potential event of us flipping a switch to enable them on release. Keeping parity with release in performance-critical parts also prevents us from optimizing the wrong paths.

Thanks for the quick reviews!
Summary: Remove or delay redundant JS(M) imports → Remove or delay redundant JS(M) imports in WebcompatReporter
Merged patches.
Attachment #8664265 - Attachment is obsolete: true
Attachment #8664384 - Attachment is obsolete: true
Attachment #8665571 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/be95d7340fb4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.