1207191 - Remove or delay redundant JS(M) imports in WebcompatReporter

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Eugen Sawin [:esawin]]

Importing JS(M) modules has a great impact on startup performance on Android, so we should not import modules pre-maturely and delay importing where possible.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1207191-Remove-unused-imports-in-WebcompatReport.patch

I don't see these modules being used there and importing JNI.jsm early during startup has a negative effect on performance (bug 1202697) on Nightly.

Comment 2

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1207191-Delay-imports-in-WebcompatReporter.js.-r.patch

Sorry, I've missed to merge this part. We can delay importing this module until the first call to reportIssue.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8664384 [details] [diff] [review]
0001-Bug-1207191-Delay-imports-in-WebcompatReporter.js.-r.patch

WebcompatReporter.js is only used in Nightly builds btw. :)

Comment 4

[Eugen Sawin [:esawin]]

(In reply to Sebastian Kaspari (:sebastian) from comment #3)
> Comment on attachment 8664384 [details] [diff] [review]
> 0001-Bug-1207191-Delay-imports-in-WebcompatReporter.js.-r.patch
> 
> WebcompatReporter.js is only used in Nightly builds btw. :)

I'm aware of that, but I would prefer to keep Nightly-only features tidy, too, for the potential event of us flipping a switch to enable them on release. Keeping parity with release in performance-critical parts also prevents us from optimizing the wrong paths.

Thanks for the quick reviews!

Comment 5

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1207191-Remove-and-delay-imports-in-WebcompatRep.patch

Merged patches.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be95d7340fb4

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be95d7340fb4