1207193 - Clone FxOS HW headers into local checkouts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Bluedroid's configuration headers move to https://github.com/mozilla-b2g/platform_hardware_libhardware_moz . Other headers will certainly follow.

The repository has to be cloned for all devices.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request

Moving this pull request over from bug 1196148.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request

Comment 3

[Kai-Zhen Li [:seinlin][:kli]]

Thomas, The patch for manifest looks good if the concern of different device use the same repo and branch of 'platform_hardware_libhardware_moz' is clarified.

So I'd like go confirm something. The header file in 'platform_hardware_libhardware_moz' is more likely a device dependent file. Is it any concern for bluedroid if all device use the same repo and branch? 
Such as: not all devices support BLE, but BLE_INCLUDED is alway define as TRUE.

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi!

Yes, it's OK. The repo is supposed to contain low-level, hardware-independent C interfaces and related files.

The Bluetooth header file is for configuration and is currently located in Gecko's repository. [1] So Bluedroid drivers on all our devices include it already.

Drivers don't include the file directly, but via a device-specific header file in the device repository, such as [2]. If there are systems with special requirements, we can override any settings there.

[1] https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluedroid/b2g_bdroid_buildcfg.h
[2] https://github.com/mozilla-b2g/device-flame/blob/kitkat/bluetooth/bdroid_buildcfg.h

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Please see comment 4.

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8665839 [details] [review]
Github pull request

Looks good to me.

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8665839 [details] [review]
Github pull request

Updated Github pull request

  - rebased onto latest master

Comment 8

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/b2g-manifest/commit/d065522e9538632d94a323afca54918ae7cb3c4c

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Carsten,

I'm not sure if anything is missing here, but from my side this bug can be resolved as FIXED.

Comment 10

[Carsten Book [:Tomcat]]

ups forgot to mark the bug as fixed, sorry thomas