Closed Bug 1207201 Opened 9 years ago Closed 9 years ago

Fix tab selection bugs

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: mhaigh, Assigned: mhaigh)

References

Details

Attachments

(1 file)

MozReview Request: Bug 1207201 - Fix tab selection bugs; r?mcomella
40 bytes, text/x-review-board-request
mcomella
: review+
Details 
Bug 1203122 attempted to fix some code with tab selection on GB devices, but introduced some further bugs to do with tab selection when there are more items than will fit on the screen which need to be fixed.
Bug 1207201 - Fix tab selection bugs; r?mcomella

In bug 1203122 we loop through only the visible tab items in the tab grid, however this causes some issues around tab selection.  This fix iterates over all items and checks/unchecks as needed
Attachment #8664274 - Flags: review?(michael.l.comella)
Comment on attachment 8664274 [details]
MozReview Request: Bug 1207201 - Fix tab selection bugs; r?mcomella

https://reviewboard.mozilla.org/r/19943/#review18003
Attachment #8664274 - Flags: review?(michael.l.comella) → review+
That last one was a mistake!  backed out!
https://hg.mozilla.org/mozilla-central/rev/015612bc2208
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: