1207236 - ARM64: Build errors with --enable-simulator=arm64

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Victor Carlquist]

Hi guys,
I'm getting the following errors with --enable-simulator=arm64:

In file included from /home/victor/Documentos/firefox/SpiderMonkey/js/src/_DBG_OBJ/js/src/Unified_cpp_js_src13.cpp:2:0:
/home/victor/Documentos/firefox/SpiderMonkey/js/src/vm/TaggedProto.cpp:8:1: error: ‘js’ has not been declared
 js::InternalGCMethods<TaggedProto>::preBarrier(TaggedProto& proto)
 ^
/home/victor/Documentos/firefox/SpiderMonkey/js/src/vm/TaggedProto.cpp:8:22: error: expected initializer before ‘<’ token
 js::InternalGCMethods<TaggedProto>::preBarrier(TaggedProto& proto)
                      ^
/home/victor/Documentos/firefox/SpiderMonkey/js/src/vm/TaggedProto.cpp:14:1: error: ‘js’ has not been declared
 js::InternalGCMethods<TaggedProto>::postBarrier(TaggedProto* vp, TaggedProto prev, TaggedProto next)
 ^
/home/victor/Documentos/firefox/SpiderMonkey/js/src/vm/TaggedProto.cpp:14:22: error: expected initializer before ‘<’ token
 js::InternalGCMethods<TaggedProto>::postBarrier(TaggedProto* vp, TaggedProto prev, TaggedProto next)
                      ^
make[3]: ** [Unified_cpp_js_src13.o] Erro 1

Comment 1

[Victor Carlquist]

Attachment: Patch

Comment 2

[Hannes Verschore [:h4writer]]

Comment on attachment 8664337 [details] [diff] [review]
Patch

Review of attachment 8664337 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: js/src/vm/TaggedProto.cpp
@@ +5,5 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +#include "TaggedProto.h"
> +
> +using namespace js;

can you do:

namespace js {

@@ +20,5 @@
>      JSObject* prevObj = prev.isObject() ? prev.toObject() : nullptr;
>      JSObject* nextObj = next.isObject() ? next.toObject() : nullptr;
>      InternalGCMethods<JSObject*>::postBarrier(reinterpret_cast<JSObject**>(vp), prevObj,
>                                                nextObj);
>  }

} // namespace js

Comment 3

[Victor Carlquist]

Attachment: Patch

Comment 4

[Victor Carlquist]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5299f425b61c

Comment 5

[Victor Carlquist]

Attachment: Patch

The try is red because I forgot to add the "vm/" in the #include.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=48a8cbc7dd72

Comment 6

[Victor Carlquist]

Try is green (comment 5)!
Thanks for your review Hannes.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9048d24f6fd0

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9048d24f6fd0