Add a test for creating a bookmark using the bookmark properties dialog.

RESOLVED FIXED in Firefox 44

Status

()

Firefox
Bookmarks & History
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: adw, Assigned: adw)

Tracking

Trunk
Firefox 44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
We need a test to make sure the fix for bug 1206376 is correct and not regressed in the future.

Updated

2 years ago
Priority: -- → P2
(Assignee)

Comment 1

2 years ago
Created attachment 8670584 [details] [diff] [review]
patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6373757d1d1d
Assignee: nobody → adw
Status: NEW → ASSIGNED
Attachment #8670584 - Flags: review?(mak77)
Comment on attachment 8670584 [details] [diff] [review]
patch

Review of attachment 8670584 [details] [diff] [review]:
-----------------------------------------------------------------

sorry, I should have told that we don't want to add further tests to browser_bookmarkProperties.js, that test is going to be splitted (I modified bug 1160326 to clarify that).
a Bunch of tests have already been splitted or created from scratch, see:
http://mxr.mozilla.org/mozilla-central/find?text=&kind=text&string=browser_bookmarkP

I think it should be much easier to modify browser_bookmarkProperties_addFolderDefaultButton.js than to write a completely new test. Instead of calling new folder on UnfiledBookmarks it should likely first create a bookmark into Unfiled and then issue New Folder on that bookmark (usually we always insert before).
Note the test is checking PlacesUtils.bookmarks.DEFAULT_INDEX and that is why it didn't catch the original bug.
Attachment #8670584 - Flags: review?(mak77)
(Assignee)

Comment 3

2 years ago
Created attachment 8672071 [details] [diff] [review]
patch v2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e58d710188aa
Attachment #8670584 - Attachment is obsolete: true
Attachment #8672071 - Flags: review?(mak77)

Updated

2 years ago
Attachment #8672071 - Flags: review?(mak77) → review+
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/9b068db8677f
https://hg.mozilla.org/mozilla-central/rev/9b068db8677f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
You need to log in before you can comment on or make changes to this bug.