1207246 - Add a test for creating a bookmark using the bookmark properties dialog.

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Drew Willcoxon :adw]

We need a test to make sure the fix for bug 1206376 is correct and not regressed in the future.

Comment 1

[Drew Willcoxon :adw]

Attachment: patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6373757d1d1d

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8670584 [details] [diff] [review]
patch

Review of attachment 8670584 [details] [diff] [review]:
-----------------------------------------------------------------

sorry, I should have told that we don't want to add further tests to browser_bookmarkProperties.js, that test is going to be splitted (I modified bug 1160326 to clarify that).
a Bunch of tests have already been splitted or created from scratch, see:
http://mxr.mozilla.org/mozilla-central/find?text=&kind=text&string=browser_bookmarkP

I think it should be much easier to modify browser_bookmarkProperties_addFolderDefaultButton.js than to write a completely new test. Instead of calling new folder on UnfiledBookmarks it should likely first create a bookmark into Unfiled and then issue New Folder on that bookmark (usually we always insert before).
Note the test is checking PlacesUtils.bookmarks.DEFAULT_INDEX and that is why it didn't catch the original bug.

Comment 3

[Drew Willcoxon :adw]

Attachment: patch v2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e58d710188aa

Comment 4

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/fx-team/rev/9b068db8677f

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b068db8677f