1207267 - No horizontal border between toolbar and folder pane and message pane

Status: RESOLVED FIXED

Description

[Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout)]

Created attachment 8664386 [details]
screenshot of issue

Thunderbird 44.0a1 20150922

Comment 1

[Richard Marti (:Paenglab)]

Aryx, on which OS is this?

Comment 2

[Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout)]

Sorry, Windows 8.1 64 bit, 1.25 device pixel ratio.

Comment 3

[Richard Marti (:Paenglab)]

I see the border all the time in my 8.1 VM scaled with 100% and also 125% and 130%. Also tried with layout.css.devPixelsPerPx set to 1.25.

Do you have somewhere a style which removes the rule at https://dxr.mozilla.org/comm-central/source/mail/themes/windows/mail/primaryToolbar.css?offset=0#1940 ?

Comment 4

[Richard Marti (:Paenglab)]

Maybe we need to implement something like https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#108

Comment 5

[Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout)]

When launched in safe mode, I see the line until I select the window (is not selected, maybe because of the dialog to confirm the safe mode). Then the space between the tab and the top edge of the window widens and the line disappears.

Comment 6

[Richard Marti (:Paenglab)]

Created attachment 8664435 [details] [diff] [review]
Bug1207267.patch

Aryx, please can you try this patch if this would solve your issue?

Comment 7

[Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout)]

Comment on attachment 8664435 [details] [diff] [review]
Bug1207267.patch

Review of attachment 8664435 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, after applying the patch, the issue seems to be gone.

Comment 8

[Richard Marti (:Paenglab)]

Created attachment 8664464 [details] [diff] [review]
Bug1207267.patch

Thank you, Aryx. I checked the patch also under Win 7 and 10.

Comment 9

[Richard Marti (:Paenglab)]

Created attachment 8664786 [details] [diff] [review]
Bug1207267.patch

Added Linux and OS X using the same logic.

Comment 10

[Philipp Kewisch [:Fallen]]

Comment on attachment 8664786 [details] [diff] [review]
Bug1207267.patch

Review of attachment 8664786 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks fine to me, if the visuals are also good then this should be ok :) r=philipp

Comment 11

[Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/comm-central/rev/303fcd96901f