Closed
Bug 1207267
Opened 6 years ago
Closed 6 years ago
No horizontal border between toolbar and folder pane and message pane
Categories
(Thunderbird :: Theme, defect)
Thunderbird
Theme
Tracking
(thunderbird42 unaffected, thunderbird43 affected, thunderbird44 affected)
RESOLVED
FIXED
Thunderbird 44.0
Tracking | Status | |
---|---|---|
thunderbird42 | --- | unaffected |
thunderbird43 | --- | affected |
thunderbird44 | --- | affected |
People
(Reporter: aryx, Assigned: Paenglab)
Details
(Keywords: regression)
Attachments
(2 files, 2 obsolete files)
5.59 KB,
image/png
|
Details | |
4.63 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
Thunderbird 44.0a1 20150922
Assignee | ||
Comment 1•6 years ago
|
||
Aryx, on which OS is this?
![]() |
Reporter | |
Comment 2•6 years ago
|
||
Sorry, Windows 8.1 64 bit, 1.25 device pixel ratio.
Assignee | ||
Comment 3•6 years ago
|
||
I see the border all the time in my 8.1 VM scaled with 100% and also 125% and 130%. Also tried with layout.css.devPixelsPerPx set to 1.25. Do you have somewhere a style which removes the rule at https://dxr.mozilla.org/comm-central/source/mail/themes/windows/mail/primaryToolbar.css?offset=0#1940 ?
Assignee | ||
Comment 4•6 years ago
|
||
Maybe we need to implement something like https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#108
![]() |
Reporter | |
Comment 5•6 years ago
|
||
When launched in safe mode, I see the line until I select the window (is not selected, maybe because of the dialog to confirm the safe mode). Then the space between the tab and the top edge of the window widens and the line disappears.
Assignee | ||
Comment 6•6 years ago
|
||
Aryx, please can you try this patch if this would solve your issue?
Attachment #8664435 -
Flags: feedback?(aryx.bugmail)
![]() |
Reporter | |
Comment 7•6 years ago
|
||
Comment on attachment 8664435 [details] [diff] [review] Bug1207267.patch Review of attachment 8664435 [details] [diff] [review]: ----------------------------------------------------------------- Yes, after applying the patch, the issue seems to be gone.
Attachment #8664435 -
Flags: feedback?(aryx.bugmail) → feedback+
Assignee | ||
Comment 8•6 years ago
|
||
Thank you, Aryx. I checked the patch also under Win 7 and 10.
Assignee: nobody → richard.marti
Attachment #8664435 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8664464 -
Flags: review?(philipp)
Assignee | ||
Comment 9•6 years ago
|
||
Added Linux and OS X using the same logic.
Attachment #8664464 -
Attachment is obsolete: true
Attachment #8664464 -
Flags: review?(philipp)
Attachment #8664786 -
Flags: review?(philipp)
Comment 10•6 years ago
|
||
Comment on attachment 8664786 [details] [diff] [review] Bug1207267.patch Review of attachment 8664786 [details] [diff] [review]: ----------------------------------------------------------------- Code looks fine to me, if the visuals are also good then this should be ok :) r=philipp
Attachment #8664786 -
Flags: review?(philipp) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
![]() |
Reporter | |
Comment 11•6 years ago
|
||
https://hg.mozilla.org/comm-central/rev/303fcd96901f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 44.0
You need to log in
before you can comment on or make changes to this bug.
Description
•