ng-class the min-width for job-tabs-panel for Talos vs. non-Talos jobs

VERIFIED FIXED

Status

Tree Management
Treeherder
P3
minor
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: jfrench, Assigned: jfrench)

Tracking

Details

Attachments

(1 attachment)

47 bytes, text/x-github-pull-request
emorley
: review+
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
I just landed a quick fix for bug 1207163 so selected Talos jobs don't wrap the pinboard^ and [x] close buttons at smaller browser widths.

Perhaps we can go one better and dynamically apply an override ng-class min-width on #job-tabs-panel if the selected job is Talos (5 tabs), and use the previous min-width for all other jobs (4 tabs).

Sizes are:

min-width: 565px (4 tabs)
min-width: 625px (5 tabs, Talos)

That way we'll maximize the users' experience and will collapse the Pinboard^ and [x] buttons a little further when only 4 tabs are visible.
(Assignee)

Updated

2 years ago
See Also: → bug 1207163
(Assignee)

Updated

2 years ago
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
(Assignee)

Comment 1

2 years ago
Created attachment 8665403 [details] [review]
PR 1002

PR for review :)
Attachment #8665403 - Flags: review?(emorley)

Updated

2 years ago
Attachment #8665403 - Flags: review?(emorley) → review+

Comment 2

2 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f639b257466217e3b5cb2caf9c990508f1fedf22
Bug 1207304 - Dynamically set the min-width for job-tabs-panel

This sets a dyanmic width for the job-tabs-panel so when non-Talos
jobs are selected, we optimize the resize experience at small browser
widths since only 4 tabs are visible.

When Talos jobs are selected, we increase the size accordingly
to accommodate 5 tabs.
(Assignee)

Comment 3

2 years ago
Marking fixed per above merge. Will verify on the next push to stage/prod.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

2 years ago
Verified fixed on stage.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.