1207304 - ng-class the min-width for job-tabs-panel for Talos vs. non-Talos jobs

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Jonathan French (:jfrench)]

I just landed a quick fix for bug 1207163 so selected Talos jobs don't wrap the pinboard^ and [x] close buttons at smaller browser widths.

Perhaps we can go one better and dynamically apply an override ng-class min-width on #job-tabs-panel if the selected job is Talos (5 tabs), and use the previous min-width for all other jobs (4 tabs).

Sizes are:

min-width: 565px (4 tabs)
min-width: 625px (5 tabs, Talos)

That way we'll maximize the users' experience and will collapse the Pinboard^ and [x] buttons a little further when only 4 tabs are visible.

Comment 1

[Jonathan French (:jfrench)]

Attachment: PR 1002

PR for review :)

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f639b257466217e3b5cb2caf9c990508f1fedf22
Bug 1207304 - Dynamically set the min-width for job-tabs-panel

This sets a dyanmic width for the job-tabs-panel so when non-Talos
jobs are selected, we optimize the resize experience at small browser
widths since only 4 tabs are visible.

When Talos jobs are selected, we increase the size accordingly
to accommodate 5 tabs.

Comment 3

[Jonathan French (:jfrench)]

Marking fixed per above merge. Will verify on the next push to stage/prod.

Comment 4

[Jonathan French (:jfrench)]

Verified fixed on stage.