Closed
Bug 1207320
Opened 10 years ago
Closed 10 years ago
update or remove logilab-common and logilab-astng
Categories
(support.mozilla.org :: Code Quality, task)
support.mozilla.org
Code Quality
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: willkg, Assigned: willkg)
References
Details
We're using:
logilab-common ==0.50.3 1.0.2 insecure
logilab-astng ==0.20.1 0.24.3 outdated
We should update them.
However, then I wondered what's using them and did some poking around and I'm not sure we're using them at all.
This bug covers figuring out whether we're actually using them and if so, update them. And if not, DESTROY THEM WITH FIRE!
|
Assignee | |
Comment 1•10 years ago
|
||
Both packages have a top-level of "logilab". Doing a grep in kitsune/ for "logilab" produces zilch. Doing a grep in the virtualenv for "logilab" shows only logilab code.
Given that I think this isn't used.
Grabbing this to remove now.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Comment 3•10 years ago
|
||
Landed in https://github.com/mozilla/kitsune/commit/096196c0845e6a71e1a54e367ba5a37538d96c50
It's removing two requirements that we don't use, so I'm just going to mark this FIXED.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•