Closed Bug 1207423 Opened 9 years ago Closed 8 years ago

Remove Apps from Tools menu

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 46
Tracking Flags:
Tracking Status
firefox44 --- verified
firefox45 --- verified
firefox46 --- verified

People

(Reporter: clouserw, Assigned: dao)

Details

Attachments

(2 files)

patch
2.17 KB, patch
Gijs
: review+
Details | Diff | Splinter Review
patch for uplift
1.18 KB, patch
ritu
: approval-mozilla-aurora+
ritu
: approval-mozilla-beta+
Details | Diff | Splinter Review 
If you click the Tools menu there is an Apps option pointing at marketplace.firefox.com.  Please remove it.  See bug 1031018 for the patch that added it.
These three bugs are friends:  bug 1207422, bug 1207423, bug 1207424
Assignee: nobody → dao
Attached patch patch — — Splinter Review 

        Attachment #8704563 -
        Flags: review?(gijskruitbosch+bugs)

    
  

        Attachment #8704563 -
        Flags: review?(gijskruitbosch+bugs) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/64a9ac1e6769
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox46:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch for uplift
        — 
          — Splinter Review
      

    


  
This is without they string removal since we don't need that for uplift.

Approval Request Comment
[Feature/regressing bug #]: deprecation of marketplace.firefox.com for desktop
[User impact if declined]: marketplace.firefox.com is being advertised when we don't want that
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: straightforward code removal, no risk
[String/UUID change made/needed]:

        Attachment #8705092 -
        Flags: approval-mozilla-beta?

        Attachment #8705092 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 8705092 [details] [diff] [review]
patch for uplift

Makes sense, taking it. beta44+, aurora45+

        Attachment #8705092 -
        Flags: approval-mozilla-beta?

        Attachment #8705092 -
        Flags: approval-mozilla-beta+

        Attachment #8705092 -
        Flags: approval-mozilla-aurora?

        Attachment #8705092 -
        Flags: approval-mozilla-aurora+

    
    

    
  
Florin, could your team please verify this menu option is gone? Thanks!
Flags: needinfo?(florin.mezei)
Flags: qe-verify+
Flags: needinfo?(florin.mezei)
Flags: needinfo?(andrei.vaida)

    
    

    
  
Reproduced the initial issue using Aurora from 45.0a2 from 2015-01-06. Verified that the issue does not reproduce on Firefox 44 beta 7 across platforms (Windows 10 x86, Mac OS X 10.11 and Ubuntu 14.04 x64). 

Leaving qe+ as a reminder for verification on other branches.

          status-firefox44:
          fixed → verified
Flags: needinfo?(andrei.vaida)

    
    

    
  
I have reproduced this bug on Nightly 44.0a1 (2015-09-22) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Nightly 46.0a1!

Build ID: 20160112030227
User Agent: Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0
QA Whiteboard: [bugday-20160113]

          status-b2g-v2.5:
          fixed → ---

    
  
Status: RESOLVED → VERIFIED

          status-firefox46:
          fixed → verified

    
    

    
  
Verified as fixed using Firefox 45 beta 6 under Win 7 64-bit, Ubuntu 14.04 64-bit and Mac OS X 10.9.5.

          status-firefox45:
          fixed → verified

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: