Closed Bug 1207424 Opened 5 years ago Closed 4 years ago

Remove Apps toolbar button

Categories

(Firefox :: Menus, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 46
Tracking Status
firefox44 --- verified
firefox45 --- verified
firefox46 --- verified

People

(Reporter: clouserw, Assigned: dao)

References

Details

Attachments

(3 files)

I think hamburger menu is frowned on but I'm not sure what the actual name is, but if you click the menu button in the top right of the browser you'll see an Apps link (you might have to click customize first).

Please remove the Apps link from the menu completely.  See bug 1031019 for the patch that added it.  Thanks.
These three bugs are friends:  bug 1207422, bug 1207423, bug 1207424
Assignee: nobody → dao
Attached patch patchSplinter Review
This doesn't remove the icon from Toolbar.png and friends, I'll file a separate bug on that :/
Attachment #8705094 - Flags: review?(gijskruitbosch+bugs)
Attachment #8705094 - Flags: review?(gijskruitbosch+bugs) → review+
Summary: Remove Apps link from Firefox Menu and Customize option → Remove Apps toolbar button
https://hg.mozilla.org/mozilla-central/rev/9c82d5b244d7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Attached patch patch for auroraSplinter Review
This is without the string removal and without the BrowserOpenApps removal in case anyone still calls that function.

Approval Request Comment
[Feature/regressing bug #]: deprecation of marketplace.firefox.com for desktop
[User impact if declined]: marketplace.firefox.com is being advertised when we don't want that
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: straightforward code removal, no risk
[String/UUID change made/needed]: none
Attachment #8705586 - Flags: approval-mozilla-aurora?
Attached patch patch for betaSplinter Review
Approval Request Comment

-> see comment 5
Attachment #8705587 - Flags: approval-mozilla-beta?
Comment on attachment 8705587 [details] [diff] [review]
patch for beta

Taking this fix as I consider this critical to get our story right given the recent changes to FxOS. Beta44+, Aurora45+
Attachment #8705587 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #8705586 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Dão Gottwald [:dao] from comment #2)
> This doesn't remove the icon from Toolbar.png and friends, I'll file a
> separate bug on that :/

bug 1043864
Verified as fixed using Firefox 44 beta 8, latest Aurora 45.0a2 and latest Nightly 46.0a1 2016-01-12 under Win 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.10.5.
Depends on: 1244548
You need to log in before you can comment on or make changes to this bug.