Closed
Bug 1207435
Opened 9 years ago
Closed 9 years ago
Port carrier switches to use web components
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
Details
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
gasolin
:
review+
Tina_Hsieh
:
ui-review+
|
Details | Review |
We should port the carrier switches to use web components.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8664630 [details] [review] [gaia] KevinGrandon:bug_1207435_carrier_web_components > mozilla-b2g:master Hi Fred, Please take a look at this when you get a chance. Thanks!
Attachment #8664630 -
Flags: review?(gasolin)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8664630 [details] [review] [gaia] KevinGrandon:bug_1207435_carrier_web_components > mozilla-b2g:master Looks good to me. Though the patch changes the place of description area (which seems like a correct change). I'll flag Tina (UX) for ui review, and handover her a device to check the visual correctness.
Attachment #8664630 -
Flags: ui-review?(thsieh)
Attachment #8664630 -
Flags: review?(gasolin)
Attachment #8664630 -
Flags: review+
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8664630 [details] [review] [gaia] KevinGrandon:bug_1207435_carrier_web_components > mozilla-b2g:master It looks good. Fred and I had checked the UI with our visual designer, Helen, and agreed with this.
Attachment #8664630 -
Flags: ui-review?(thsieh) → ui-review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
In master: https://github.com/mozilla-b2g/gaia/commit/77d463a009a1425e413edaae92b237e116708560 Thanks for the reviews!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•