1207437 - Fix and disallow warnings in gfx/thebes

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nicholas Nethercote [inactive]]

We get a ton of warnings like this in gfxWindowsPlatform.cpp:

> gfx/thebes/gfxWindowsPlatform.cpp(2016) : warning C4509: nonstandard extension used: 'gfxWindowsPlatform::AttemptD3D11DeviceCreation' uses SEH and 'adapter' has destructor

The problem is that desctructors don't run reliably if a structured exception is thrown. The fix is to put the SEH try/catch blocks in functions that don't involve local variables whose types have destructors.

Comment 1

[Nicholas Nethercote [inactive]]

W.r.t. the incoming patches, please note that I'm a total newbie when it comes to this code. Please cast a skeptical eye.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Don't recompute Windows feature levels

This is valid because mFeatureLevels is set when gfxWindowsPlatform is
initialized.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Don't re-get D3D11CreateDevice

It's always obtained during gfxWindowPlatform initialization and put into
sD3D11CreateDeviceFn.

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Fix and disallow warnings in gfx/thebes/

froydnj: I'm uncertain about the handling of |aDevice| in
CreateD3D11DecoderDeviceHelper(). I've used a RefPtr<>& because of the byRef()
call but I don't know if that's right. That's the only bit I need you to look
at, but please look carefully.

dvander: please check the whole patch.

Thank you.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8664634 [details] [diff] [review]
(part 3) - Fix and disallow warnings in gfx/thebes/

Review of attachment 8664634 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me.

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8664634 [details] [diff] [review]
(part 3) - Fix and disallow warnings in gfx/thebes/

Review of attachment 8664634 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, these warnings were really annoying.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1621dcfac789
https://hg.mozilla.org/integration/mozilla-inbound/rev/9aab02e2871f
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e0a245b7492

Comment 8

[Nicholas Nethercote [inactive]]

Here's the try push I did before landing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fe57671a098

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1621dcfac789
https://hg.mozilla.org/mozilla-central/rev/9aab02e2871f
https://hg.mozilla.org/mozilla-central/rev/6e0a245b7492

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/782262a94361

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/782262a94361