1207480 - Include Bluedroid configuration from libhardware_moz

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

The build system's variable BOARD_BLUETOOTH_BDROID_BUILDCFG_INCLUDE_DIR is in the device's BoardConfig.mk.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for nexus-4

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for nexus-5-l

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for flame-kk

Comment 4

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for flame-l

Comment 5

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1207480: Remove B2G Bluedroid configuration from tree

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi Shawn,

I'm surprised that only these 4 devices seem to use B2G's Bluedroid configuration; Aries, flatfish and others apparently do not. Should be change them to include the configuration as well?

Comment 7

[Thomas Zimmermann [:tzimmermann] [:tdz]]

s/be/we

Comment 8

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #6)
> Hi Shawn,
> 
> I'm surprised that only these 4 devices seem to use B2G's Bluedroid
> configuration; Aries, flatfish and others apparently do not. Should be
> change them to include the configuration as well?

For Aries, yes, we should add it but I forgot to add it during porting stage. :(
For flatfish, probably it won't be impacted. Flatfish does not support HFP (no RIL module) and the bluedroid stack is older so it doesn't support BLE flags. One left flag SDP_AVRCP_1_5 is for bluedroid customized from CAF, AOSP bluedroid stack never uses SDP_AVRCP_1_5.

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for shinano

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for yukon

Comment 11

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi Shawn, I added pull requests for the Sony repositories.

Comment 12

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Sheriffs, please land the pulls and the Gecko patch.

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/93cc2cef6304

Comment 14

[Carsten Book [:Tomcat]]

PR:
https://github.com/mozilla-b2g/device-mako/commit/85f23c2f3410e6a555f42168f44e73777718cad1
https://github.com/mozilla-b2g/device-hammerhead/commit/22ab4b0b7fa7ed7b10c1b0576462008c53127f10
https://github.com/mozilla-b2g/device-flame/commit/205ac4204bbbb2098a8046444acba551ba5dc75a
https://github.com/mozilla-b2g/device-sony-shinano/commit/f3614b2bc780cfba38924596b43564bf628d32db
https://github.com/mozilla-b2g/device-flame/commit/ef181b718bdb68b15a5e8db200d99f151445eb6a
https://github.com/mozilla-b2g/device-sony-yukon/commit/9d4b787968046d3f5f6fd0c9419505e1307be45d

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backing out the gecko patch because device image builds are broken even after the gaia pull requests got included:

https://hg.mozilla.org/integration/b2g-inbound/rev/e16a35ee4e8c


Example failures:
https://treeherder.mozilla.org/logviewer.html#?job_id=3108280&repo=b2g-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=3108264&repo=b2g-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=3108062&repo=b2g-inbound

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

So, it looks like this gaia bump fixed the builds (even without my backout) for everything except the Aries device builds: https://hg.mozilla.org/integration/b2g-inbound/rev/e1bb533dd478

Comment 17

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for device-shinano-common

The Aries builds on Treeherder use device-aries and device-shinano-common. The latter still referred to Gecko. I think that's why the builds failed with the Gecko patch applied.

Comment 18

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks Shawn. I merged the pull request. Let's see what happens.

https://github.com/mozilla-b2g/device-shinano-common/commit/0ed85ac8d740f6980761bc58b5be952252f7ab6a

Comment 19

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for fixing device-shinano-common

A backslash was missing at an EOL in the pull request for device-shinano-common. Fixed now.

Comment 20

[Thomas Zimmermann [:tzimmermann] [:tdz]]

B2g-inbound seems to build again. Let's try the Gecko patch.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a54e6c79965

Comment 21

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Looks like Aries is still failing.

Comment 22

[Thomas Zimmermann [:tzimmermann] [:tdz]]

The latest builds on b2g-inbound look good to me. For example

  https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=84ec511f55c8

But it doesn't work on try. The repositories are there and at the correct rev. The same patches work locally with aries-l. Hmm...

Comment 23

[Thomas Zimmermann [:tzimmermann] [:tdz]]

It works locally.

Comment 24

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Testing with a fix for device-aries.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c720f546b8fd

Comment 25

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Github pull request for device-aries

Hi Shawn, this fix apparently makes aries build on the test infrastructure. The try session is linked in the comment above.

Comment 26

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Comment on attachment 8680019 [details] [review]
Github pull request for device-aries

Merged at

https://github.com/mozilla-b2g/device-aries/commit/a19052e4389c3ae2d8fc3e7a74a475401baacc56

Comment 27

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=75937fe0d55b

This commit in b2g-inbound has built successfully with the aries patch applied. I'm going land the Gecko patch again.

Comment 28

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/6557bc19271f

Comment 29

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=6557bc19271f

Comment 30

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6557bc19271f

Comment 31

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/6557bc19271f

Comment 32

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion