Wrong foreground and background colors for list item selection in list-boxes and combo-boxes in Firefox Options screen

NEW
Unassigned

Status

()

Firefox
Preferences
2 years ago
2 years ago

People

(Reporter: Kostadin Kolev, Unassigned)

Tracking

40 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150917150946

Steps to reproduce:

1. Switch to the High-Contrast Black theme in Windows.
2. Open Firefox.
3. In the "Tools" menu, click "Options".
4. From the list of categories on the left, click on "Content".
5. From the group of settings "Fonts and Colors" on the right, click on the "Colors" button.
6. If in the combo-box for choosing if Firefox will ignore the colors defined in the web pages is set to something different than "Only with high-contrast themes", set it to it.
7. Click on the "OK" button to apply the changes and close the "Colors" dialog.
8. Look at some list-box and drop-down (combo-box) controls in the "Options" screen of Firefox, specially at the currently selected item.


Actual results:

The selection is indicated only by a white rectangle around the selected item, with no change in the colors of the foreground and background colors for the selected item. This makes the visibility of witch item is selected much more difficult. In some controls, it is even worse, because there are some sort of split lines between each item, witch makes it even harder to determine witch is the currently selected item in the list. For prove, see the attached ZIP archive with screenshots. The screenshots are from v40.0 of Firefox, because due to BugĀ 1207084, the visual appearence of some of those controls has changed (but not improved).


Expected results:

In those controls, the foreground and background colors for list item selection should obey the currently used theme in Windows. In the case with the example screenshots, the selection foreground should be black and the background - cyan.
(Reporter)

Comment 1

2 years ago
Created attachment 8664705 [details]
Firefox Options screens with wrong colors for list item selection

Comment 2

2 years ago
What's the difference with your previous bug 1207084?
(In reply to Loic from comment #2)
> What's the difference with your previous bug 1207084?

See the summary and bug 1207084 comment 6. I suspect, given that this predates the cause of bug 1207084, that this will need to be fixed separately.
Depends on: 1207084
Created attachment 8688944 [details]
Desktop.7z
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151029151421

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20151117030242

I've tested this on latest release(42.0), but the issue didn't reproduce. Instead, colors from the chooser weren't visible(see attachment 42 [details] [diff] [review].0). Also, header of the opened tab was badly drawn. On the latest Nightly(45.0a1) however, the bug was present. The color chooser displayed all colors correctly, but choosing a color didn't make a difference. Changes made to the colors are visible only when opening a new tab, and the start page is set as default(see attachment Nightly).
Status: UNCONFIRMED → NEW
Component: Untriaged → Layout
Ever confirmed: true
Product: Firefox → Core
(In reply to PaulMircea from comment #5)
> User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:42.0) Gecko/20100101
> Firefox/42.0
> Build ID: 20151029151421
> 
> User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
> Firefox/45.0
> Build ID: 20151117030242
> 
> I've tested this on latest release(42.0), but the issue didn't reproduce.
> Instead, colors from the chooser weren't visible(see attachment 42 [details] [diff] [review]
> [diff] [review].0). 

Please don't attach 7-zip files; attach the relevant PNGs instead.

Also, please read bugs carefully - the issue you're describing is bug 1207084 and the details of that bug are available there.

> Also, header of the opened tab was badly drawn.

This is completely unrelated to this bug, and "badly drawn" is not descriptive.

> On the
> latest Nightly(45.0a1) however, the bug was present. The color chooser
> displayed all colors correctly, but choosing a color didn't make a
> difference. Changes made to the colors are visible only when opening a new
> tab, and the start page is set as default(see attachment Nightly).

This is really not what this bug is about, either (besides it being very hard to understand what you actually mean purely based on the 7-zip file you uploaded). It's about the selected items in listboxes and menulists / combo-boxes inside about:preferences. Please don't morph bugs without asking if you do not have context about our support and/or lack thereof for high-contrast mode.

I'm moving this bug back to Firefox::Preferences so we can make sure it behaves properly when author colors are turned off either through prefs or high contrast mode.
Component: Layout → Preferences
Product: Core → Firefox
You need to log in before you can comment on or make changes to this bug.