1207526 - [browser] add pocket shortcut in app deck

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

Description

[Dan Huang[:danhuang]]

Add a pocket shortcut in app deck. Click this shortcut would lunch the browser app and open pocket home page.

Comment 1

[Dan Huang[:danhuang]]

Hi Peko,
This bug need a icon(336 pixel) for pocket in app deck.
Please help us to create one.
Thanks

Comment 2

[Peko Chen [:pekochen]]

Attachment: Pocket_336.png

Hi,

Please check attached file : )
Thanks~

Comment 3

[Dan Huang[:danhuang]]

Attachment: pocket_336.png

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:1207526_pocket_shortcut_in_app_deck > mozilla-b2g:master

Comment 5

[Dan Huang[:danhuang]]

Comment on attachment 8668334 [details] [review]
[gaia] danhuang1202:1207526_pocket_shortcut_in_app_deck > mozilla-b2g:master

Please help to review. This patch add pocket in app deck and update openPage() in browser/js/connection_handler.js. Thanks.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8668334 [details] [review]
[gaia] danhuang1202:1207526_pocket_shortcut_in_app_deck > mozilla-b2g:master

r=me with some comments on Github. Please correct them before landing.

Comment 7

[Dan Huang[:danhuang]]

Thanks for the review. I had updated new patch for fixing all nits you point out. Thanks.

Comment 8

[Dan Huang[:danhuang]]

merge in master:
https://github.com/mozilla-b2g/gaia/commit/9a682cb7bc8b7fde624a9b2b3c2d64415a08b04b