[browser] add pocket shortcut in app deck

RESOLVED FIXED in FxOS-S9 (16Oct)

Status

P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: danhuang, Assigned: danhuang)

Tracking

unspecified
FxOS-S9 (16Oct)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.5+)

Details

(Whiteboard: [partner-cherry-picked<2015/11/10>])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Add a pocket shortcut in app deck. Click this shortcut would lunch the browser app and open pocket home page.
(Assignee)

Updated

3 years ago
Blocks: 1194109
(Assignee)

Updated

3 years ago
Assignee: nobody → dhuang
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Hi Peko,
This bug need a icon(336 pixel) for pocket in app deck.
Please help us to create one.
Thanks
Flags: needinfo?(pchen)

Updated

3 years ago
feature-b2g: --- → 2.5+
Priority: -- → P1
Target Milestone: --- → FxOS-S9 (16Oct)
(Assignee)

Updated

3 years ago
Whiteboard: [partner-cherry-pick]
Created attachment 8667735 [details]
Pocket_336.png

Hi,

Please check attached file : )
Thanks~
Flags: needinfo?(pchen)
(Assignee)

Updated

3 years ago
Depends on: 1202364
(Assignee)

Comment 3

3 years ago
Created attachment 8668322 [details]
pocket_336.png
Attachment #8667735 - Attachment is obsolete: true
Created attachment 8668334 [details] [review]
[gaia] danhuang1202:1207526_pocket_shortcut_in_app_deck > mozilla-b2g:master
(Assignee)

Comment 5

3 years ago
Comment on attachment 8668334 [details] [review]
[gaia] danhuang1202:1207526_pocket_shortcut_in_app_deck > mozilla-b2g:master

Please help to review. This patch add pocket in app deck and update openPage() in browser/js/connection_handler.js. Thanks.
Attachment #8668334 - Flags: review?(rexboy)
Comment on attachment 8668334 [details] [review]
[gaia] danhuang1202:1207526_pocket_shortcut_in_app_deck > mozilla-b2g:master

r=me with some comments on Github. Please correct them before landing.
Attachment #8668334 - Flags: review?(rexboy) → review+
(Assignee)

Comment 7

3 years ago
Thanks for the review. I had updated new patch for fixing all nits you point out. Thanks.
(Assignee)

Comment 8

3 years ago
merge in master:
https://github.com/mozilla-b2g/gaia/commit/9a682cb7bc8b7fde624a9b2b3c2d64415a08b04b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Component: Gaia::TV → Gaia::TV::Browser

Updated

3 years ago
Whiteboard: [partner-cherry-pick] → [partner-cherry-picked<2015/11/10>]
You need to log in before you can comment on or make changes to this bug.