Closed Bug 1207526 Opened 4 years ago Closed 4 years ago
[browser] add pocket shortcut in app deck
Add a pocket shortcut in app deck. Click this shortcut would lunch the browser app and open pocket home page.
Hi Peko, This bug need a icon(336 pixel) for pocket in app deck. Please help us to create one. Thanks
feature-b2g: --- → 2.5+
Priority: -- → P1
Target Milestone: --- → FxOS-S9 (16Oct)
Hi, Please check attached file : ) Thanks~
Comment on attachment 8668334 [details] [review] [gaia] danhuang1202:1207526_pocket_shortcut_in_app_deck > mozilla-b2g:master Please help to review. This patch add pocket in app deck and update openPage() in browser/js/connection_handler.js. Thanks.
Attachment #8668334 - Flags: review?(rexboy)
Comment on attachment 8668334 [details] [review] [gaia] danhuang1202:1207526_pocket_shortcut_in_app_deck > mozilla-b2g:master r=me with some comments on Github. Please correct them before landing.
Attachment #8668334 - Flags: review?(rexboy) → review+
Thanks for the review. I had updated new patch for fixing all nits you point out. Thanks.
merge in master: https://github.com/mozilla-b2g/gaia/commit/9a682cb7bc8b7fde624a9b2b3c2d64415a08b04b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [partner-cherry-pick] → [partner-cherry-picked<2015/11/10>]
You need to log in before you can comment on or make changes to this bug.