The line between the panels and the content is shorter than the width of the screen

RESOLVED FIXED in Firefox 44

Status

()

Firefox for Android
Awesomescreen
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Flaviu Cos, Assigned: sebastian)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 44
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox41 unaffected, firefox42 affected, firefox43 affected, firefox44 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8664797 [details]
panels underline.png

Environment: 
Device: Lenovo Yoga Tab 10 (Android 4.4.2);
Build: Nightly 44.0a1 (2015-09-23);

Steps to reproduce:
1. Launch fennec;
2. Observe the panels from about:home.

Expected result:
The line that separates the content form the panels is as wide as the screen.

Actual result:
The line between the panels and the content is shorter than the width of the screen.

Notes:
Please check the attached screenshot.
Sebastian, easy fix (match_parent?) or mentorable?
Blocks: 1157964
Flags: needinfo?(s.kaspari)
(Assignee)

Comment 2

3 years ago
That's interesting. I fixed something like this in bug 1186841 before. I'll have a look.
Assignee: nobody → s.kaspari
Flags: needinfo?(s.kaspari)
(Assignee)

Updated

3 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Created attachment 8665415 [details]
MozReview Request: Bug 1207554 - TabMenuStrip: Fill viewport. r?mcomella

Bug 1207554 - TabMenuStrip: Fill viewport. r?mcomella
Attachment #8665415 - Flags: review?(michael.l.comella)
(Assignee)

Comment 4

3 years ago
(In reply to Michael Comella (:mcomella) from comment #1)
> easy fix (match_parent?)

Almost! TabMenuStripLayout is already set to match_parent but the enclosing HorizontalScrollView (TabMenuStrip) ignores it unless setFillViewport(true) is called.
Ahahha I ran into this bug too while trying to figure out how to only have two title items in the TabMenuStrip for the Firstrun, and ended up with the same fix :)
Attachment #8665415 - Flags: review?(michael.l.comella) → review+
(Assignee)

Comment 8

3 years ago
(In reply to Chenxia Liu [:liuche] from comment #5)
> Ahahha I ran into this bug too while trying to figure out how to only have
> two title items in the TabMenuStrip for the Firstrun, and ended up with the
> same fix :)

Heh. Thanks for pushing the patch! :)
https://hg.mozilla.org/mozilla-central/rev/1e262cfbcda2
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
(Reporter)

Comment 10

3 years ago
Verified as fixed in build 44.0a1 2015-09-29;
Device: Asus Transformer Pad (Android 4.2.1).
status-firefox44: fixed → verified
You need to log in before you can comment on or make changes to this bug.