1207627 - Kill the markup-view preview sidebar

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Patrick Brosset <:pbro>]

It's dead code, I don't think it was ever enabled by default, it has no tests, and the value is kind of limited I believe.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug_1207627_-_Remove_the_markup-view_feature.diff

Deleting code!
NI? Jeff just to be sure you're ok with this.

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8664883 [details] [diff] [review]
Bug_1207627_-_Remove_the_markup-view_feature.diff

Review of attachment 8664883 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks.  Commit message should probably read 'markupview preview' so it doesn't look like we are removing the markup view

Comment 3

[Patrick Brosset <:pbro>]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> Comment on attachment 8664883 [details] [diff] [review]
> Bug_1207627_-_Remove_the_markup-view_feature.diff
> 
> Review of attachment 8664883 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM, thanks.  Commit message should probably read 'markupview preview' so
> it doesn't look like we are removing the markup view
Yeah, good catch.
Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a9d52f63996

Clearing NI? as I just talked to Jeff in person.

Comment 4

[Jeff Griffiths (:canuckistani) (:⚡︎)]

To be clear: kill it.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/27993f904dba

Comment 6

[Tim Nguyen :ntim]

I personally found it useful since it gave a global preview of all DOM mutations happening on the page (you can see the yellow flash on different lines in the preview). While the markup view itself only displays mutations for the current viewed markup, which is not convenient if you have various mutations happening on different parts of the dom, but at the same time.

Comment 7

[Tim Nguyen :ntim]

Also, the feature could have been much more useful if it had the click to scroll feature ST has, it's much faster to click there than actually searching a specific selector.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/27993f904dba