Closed Bug 1207632 Opened 9 years ago Closed 6 years ago

Add LLVM license to about:license for iOS builds

Categories

(mozilla.org :: Licensing, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file)

bug 1171649 is importing some code from LLVM's compiler-rt library for iOS builds. We're not shipping this code yet, so I punted on updating about:license.
bug 1207632 - about:license additions for LLVM compiler-rt files for iOS build. r?gerv
Attachment #8664888 - Flags: review?(gerv)
Comment on attachment 8664888 [details]
MozReview Request: bug 1207632 - about:license additions for LLVM compiler-rt files for iOS build. r?gerv

https://reviewboard.mozilla.org/r/20055/#review18205

r=gerv with these fixes.

Gerv

::: toolkit/content/license.html:152
(Diff revision 1)
> +#endif

Can we have these in alphabetical order please? That means moving the license block itself as well.

::: toolkit/content/license.html:5299
(Diff revision 1)
> +Copyright (c) 2009-2015 by the contributors listed in CREDITS.TXT

You need to update the path to CREDITS.TXT to say where it is in the mozilla tree.
Attachment #8664888 - Flags: review?(gerv)
https://reviewboard.mozilla.org/r/20055/#review18205

> You need to update the path to CREDITS.TXT to say where it is in the mozilla tree.

I didn't add it to the Mozilla tree in my patch. Do I need to do that, or can I just point to the file in llvm's repository?
Stick it in the Mozilla tree, please.

Gerv
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: