1207672 - Support APPLE_framebuffer_multisample on iOS

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

We use GL_EXT_framebuffer_blit, which is not available on iOS devices when using GLES2. It's built into GLES3, though, so we can use that instead.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Use a GLES3 context on iOS

Comment 2

[Jeff Gilbert [:jgilbert]]

Comment on attachment 8664968 [details] [diff] [review]
Use a GLES3 context on iOS

Review of attachment 8664968 [details] [diff] [review]:
-----------------------------------------------------------------

You should support GLES2 as well, if you want to support the 5 and 5c. (Which don't have GLES3)

As such, I don't think this is the right change.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Morphing this bug into the real issue, which is that we mis-detect whether or not the device can do separate draw/read FBs.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Add support for APPLE_framebuffer_multisample r=snorp

This patch is from Jeff, I just fixed up some typos and tested it.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Jeff, is this good to go or do you want to have someone else look at it too?

Comment 6

[Jeff Gilbert [:jgilbert]]

I wrote it and you looked at it. That should be fine.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ff6d5250364

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2ff6d5250364