Closed Bug 1207672 Opened 4 years ago Closed 4 years ago

Support APPLE_framebuffer_multisample on iOS

Categories

(Core :: Graphics, defect)

41 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: snorp, Unassigned)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file, 1 obsolete file)

We use GL_EXT_framebuffer_blit, which is not available on iOS devices when using GLES2. It's built into GLES3, though, so we can use that instead.
Attached patch Use a GLES3 context on iOS (obsolete) — Splinter Review
Attachment #8664968 - Flags: review?(jgilbert)
Comment on attachment 8664968 [details] [diff] [review]
Use a GLES3 context on iOS

Review of attachment 8664968 [details] [diff] [review]:
-----------------------------------------------------------------

You should support GLES2 as well, if you want to support the 5 and 5c. (Which don't have GLES3)

As such, I don't think this is the right change.
Attachment #8664968 - Flags: review?(jgilbert) → review-
Morphing this bug into the real issue, which is that we mis-detect whether or not the device can do separate draw/read FBs.
Summary: Use a GLES3 context on iOS → Support APPLE_framebuffer_multisample on iOS
This patch is from Jeff, I just fixed up some typos and tested it.
Attachment #8666048 - Flags: review+
Jeff, is this good to go or do you want to have someone else look at it too?
Flags: needinfo?(jgilbert)
Attachment #8664968 - Attachment is obsolete: true
I wrote it and you looked at it. That should be fine.
Flags: needinfo?(jgilbert)
Whiteboard: [gfx-noted]
https://hg.mozilla.org/mozilla-central/rev/2ff6d5250364
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.