Closed Bug 1207719 Opened 6 years ago Closed 5 years ago

Change Switchboard to combine network requests for experiments and server configurations into a single network fetch

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(firefox47 wontfix, firefox48 fixed)

RESOLVED FIXED
Firefox 48
Tracking Status
firefox47 --- wontfix
firefox48 --- fixed

People

(Reporter: mfinkle, Assigned: Margaret)

References

Details

Attachments

(2 files)

Switchboard uses two separate network calls to pull down JSON for experiment configuration and server URL configuration. We should make this the same, single call.
Miles added a v2 endpoint that combines the JSON blobs from the current two endpoints into a single endpoint:
https://github.com/leibovic/switchboard-server/blob/master/lib/app.js#L111

We should update the client to use this.
Assignee: nobody → margaret.leibovic
I was pretty aggressive about modifying this to suit our needs, removing things that we weren't using.

There's a lot more clean-up we can do in here, but I didn't want to scope creep this too much :)

Also, I started to try to write some unit tests, but I'm not sure of the best way to test these server interactions. Maybe you have some ideas after working on the DLC tests.
Blocks: 1261713
Attachment #8737642 - Flags: review?(s.kaspari) → review+
Comment on attachment 8737642 [details]
MozReview Request: Bug 1207719 - (Part 1) Convert tabs to spaces. r=sebastian

https://reviewboard.mozilla.org/r/44041/#review40613
Attachment #8737643 - Flags: review?(s.kaspari) → review+
Comment on attachment 8737643 [details]
MozReview Request: Bug 1207719 - (Part 2) Change Switchboard to combine network requests for experiments and server configurations into a single network fetch. r=sebastian

https://reviewboard.mozilla.org/r/44043/#review40617

Nice :)
https://hg.mozilla.org/integration/fx-team/rev/0912147b690ebe731de6c976e30cfd821c99ed6c
Bug 1207719 - (Part 1) Convert tabs to spaces. r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/43138b644a40880ef532d6fb8e43ef16b446d266
Bug 1207719 - (Part 2) Change Switchboard to combine network requests for experiments and server configurations into a single network fetch. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/0912147b690e
https://hg.mozilla.org/mozilla-central/rev/43138b644a40
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Depends on: 1262811
Comment on attachment 8737642 [details]
MozReview Request: Bug 1207719 - (Part 1) Convert tabs to spaces. r=sebastian

Required for bug 1270929. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1270929#c9
Attachment #8737642 - Flags: approval-mozilla-beta?
Comment on attachment 8737643 [details]
MozReview Request: Bug 1207719 - (Part 2) Change Switchboard to combine network requests for experiments and server configurations into a single network fetch. r=sebastian

Required for bug 1270929. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1270929#c9
Attachment #8737643 - Flags: approval-mozilla-beta?
We decided to not uplift bug 1270929 to Beta, we'll let this one also ride the Aurora48 to Beta48 train.
Attachment #8737642 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Attachment #8737643 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.