1207719 - Change Switchboard to combine network requests for experiments and server configurations into a single network fetch

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Switchboard uses two separate network calls to pull down JSON for experiment configuration and server URL configuration. We should make this the same, single call.

Comment 1

[:Margaret Leibovic]

Miles added a v2 endpoint that combines the JSON blobs from the current two endpoints into a single endpoint:
https://github.com/leibovic/switchboard-server/blob/master/lib/app.js#L111

We should update the client to use this.

Comment 2

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1207719 - (Part 1) Convert tabs to spaces. r=sebastian

Review commit: https://reviewboard.mozilla.org/r/44041/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44041/

Comment 3

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1207719 - (Part 2) Change Switchboard to combine network requests for experiments and server configurations into a single network fetch. r=sebastian

Review commit: https://reviewboard.mozilla.org/r/44043/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44043/

Comment 4

[:Margaret Leibovic]

I was pretty aggressive about modifying this to suit our needs, removing things that we weren't using.

There's a lot more clean-up we can do in here, but I didn't want to scope creep this too much :)

Also, I started to try to write some unit tests, but I'm not sure of the best way to test these server interactions. Maybe you have some ideas after working on the DLC tests.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8737642 [details]
MozReview Request: Bug 1207719 - (Part 1) Convert tabs to spaces. r=sebastian

https://reviewboard.mozilla.org/r/44041/#review40613

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8737643 [details]
MozReview Request: Bug 1207719 - (Part 2) Change Switchboard to combine network requests for experiments and server configurations into a single network fetch. r=sebastian

https://reviewboard.mozilla.org/r/44043/#review40617

Nice :)

Comment 7

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/0912147b690ebe731de6c976e30cfd821c99ed6c
Bug 1207719 - (Part 1) Convert tabs to spaces. r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/43138b644a40880ef532d6fb8e43ef16b446d266
Bug 1207719 - (Part 2) Change Switchboard to combine network requests for experiments and server configurations into a single network fetch. r=sebastian

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0912147b690e
https://hg.mozilla.org/mozilla-central/rev/43138b644a40

Comment 9

[:Margaret Leibovic]

Comment on attachment 8737642 [details]
MozReview Request: Bug 1207719 - (Part 1) Convert tabs to spaces. r=sebastian

Required for bug 1270929. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1270929#c9

Comment 10

[:Margaret Leibovic]

Comment on attachment 8737643 [details]
MozReview Request: Bug 1207719 - (Part 2) Change Switchboard to combine network requests for experiments and server configurations into a single network fetch. r=sebastian

Required for bug 1270929. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1270929#c9

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

We decided to not uplift bug 1270929 to Beta, we'll let this one also ride the Aurora48 to Beta48 train.