1207736 - [Music][NGA] Thumbnails missing for list views

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Music, defect, P1)

Description

[Justin D'Arcangelo [:justindarc]]

We are now un-blocked from adding thumbnail images to list views:

https://github.com/gaia-components/gaia-fast-list/pull/8

We need to add thumbnail images in the correct places to mirror the existing functionality of Music OGA.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] justindarc:bug1207736 > mozilla-b2g:master

Comment 2

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8665123 [details] [review]
[gaia] justindarc:bug1207736 > mozilla-b2g:master

squib: We should be "feature complete" after this patch :-)

Comment 3

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/165a95e25c03c342f1a134ec0afcee264924ec58

Comment 4

[Jessica]

Attachment: Flame_KK v2.5.3gp

Hi Justin,
    I have verified this issue on latest build of Flame KK v2.5, but it still seems not well, and some thumbnails are missing. When you pan down up the list, some thumbnails could be displayed but some can't still.
See attachment: Flame_KK v2.5.3gp and logcat_0018.txt

Device: Flame KK v2.5
Build ID               20150928150204
Gaia Revision          01ffe82cf088ca8fda9fe6783dc5cad2c3dde01c
Gaia Date              2015-09-28 08:49:32
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/031db40e2b558c7e4dd0b4c565db4a992c1627c8
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150928.182514
Firmware Date          Mon Sep 28 18:25:26 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 5

[Jessica]

Attachment: logcat_0018.txt

Comment 6

[Justin D'Arcangelo [:justindarc]]

(In reply to Jessica from comment #4)
> Created attachment 8667078 [details]
> Flame_KK v2.5.3gp
> 
> Hi Justin,
>     I have verified this issue on latest build of Flame KK v2.5, but it
> still seems not well, and some thumbnails are missing. When you pan down up
> the list, some thumbnails could be displayed but some can't still.
> See attachment: Flame_KK v2.5.3gp and logcat_0018.txt
> 
> Device: Flame KK v2.5
> Build ID               20150928150204
> Gaia Revision          01ffe82cf088ca8fda9fe6783dc5cad2c3dde01c
> Gaia Date              2015-09-28 08:49:32
> Gecko Revision        
> https://hg.mozilla.org/mozilla-central/rev/
> 031db40e2b558c7e4dd0b4c565db4a992c1627c8
> Gecko Version          44.0a1
> Device Name            flame
> Firmware(Release)      4.4.2
> Firmware(Incremental)  eng.cltbld.20150928.182514
> Firmware Date          Mon Sep 28 18:25:26 EDT 2015
> Firmware Version       v18D v4
> Bootloader             L1TC000118D0

Hmm.. May be an issue with the <gaia-fast-list>. Setting NI? for :wilsonpage.

Comment 7

[Wilson Page [:wilsonpage]]

I haven't been able to reproduce the bug that can be seen in the video. I'm guessing it could be a race condition to do with the code that revokes the ObjectURL [1].

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/music/views/songs/view.js#L108

Comment 8

[Justin D'Arcangelo [:justindarc]]

(In reply to Wilson Page [:wilsonpage] from comment #7)
> I haven't been able to reproduce the bug that can be seen in the video. I'm
> guessing it could be a race condition to do with the code that revokes the
> ObjectURL [1].
> 
> [1]
> https://github.com/mozilla-b2g/gaia/blob/master/apps/music/views/songs/view.
> js#L108

It could either be that or maybe related to Bug 1209716 which is about an album art race condition. Re-opening to take a closer look.

Comment 9

[Jim Porter (:squib)]

Wait a second... NGA music isn't actually using the album art cache correctly. album_art_cache.js manages caching of blob: URLs so that they never get revoked. While we could move this behavior out of album_art_cache.js and into something else, we should probably have some kind of session cache for blob: URLs.

Comment 10

[Jim Porter (:squib)]

Is this still an issue? Based on the description, this seems to be working fine now.

Comment 11

[Justin D'Arcangelo [:justindarc]]

Not working on this. Unassigning myself.

Comment 12

[BMO Automation]

Firefox OS is not being worked on