Closed
Bug 1207770
Opened 9 years ago
Closed 9 years ago
Add no ril device on TaskCluster
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sousmangoosta, Assigned: sousmangoosta)
Details
(Whiteboard: [b2g-build-support])
Attachments
(1 file, 2 obsolete files)
3.00 KB,
patch
|
garndt
:
review+
|
Details | Diff | Splinter Review |
We don't have a NO RIL TaskCluster image builded on try and other branches. Can be source of bug on tablet builds where used of disable-b2g-ril.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8665089 -
Flags: review?(garndt)
Assignee | ||
Comment 2•9 years ago
|
||
I pushed a try job here https://treeherder.mozilla.org/#/jobs?repo=try&revision=75e2d68df396
Comment 3•9 years ago
|
||
Comment on attachment 8665089 [details] [diff] [review] Use aries existant image with an env variables to simulate no ril device Review of attachment 8665089 [details] [diff] [review]: ----------------------------------------------------------------- Looks like this is orange on TH. Also, we should ask the sheriffs if this should be reporting to TH production. I'm not sure what visibility should be set for a job like this. Also, this has the same symbol as the regular build, so we might want to make it unique so there aren't more than one 'B' symbol. Thanks for working on this!
Attachment #8665089 -
Flags: review?(garndt) → review-
Assignee | ||
Comment 4•9 years ago
|
||
It should be orange until Bug 1207266 be landed. Will try do better tomorrow for the symbol.
Assignee | ||
Comment 5•9 years ago
|
||
The try with additionnaly the patch of Bug 1207266 looks good : https://treeherder.mozilla.org/#/jobs?repo=try&revision=2613cebacfc8
Updated•9 years ago
|
Component: General → Task Configuration
Whiteboard: [tc-build-support]
Updated•9 years ago
|
Whiteboard: [tc-build-support] → [b2g-build-support]
Assignee | ||
Comment 6•9 years ago
|
||
This build passed try : https://treeherder.mozilla.org/#/jobs?repo=try&revision=096835397c3b&selectedJob=14227718
Attachment #8665089 -
Attachment is obsolete: true
Comment 7•9 years ago
|
||
(In reply to Greg Arndt [:garndt] from comment #3) > Comment on attachment 8665089 [details] [diff] [review] > Use aries existant image with an env variables to simulate no ril device > > Review of attachment 8665089 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks like this is orange on TH. Also, we should ask the sheriffs if this > should be reporting to TH production. I'm not sure what visibility should > be set for a job like this. Also, this has the same symbol as the regular > build, so we might want to make it unique so there aren't more than one 'B' > symbol. > > Thanks for working on this! Hi Roland, we have visibility requirements here https://wiki.mozilla.org/Sheriffing/Job_Visibility_Policy#Requirements_for_jobs_shown_in_the_default_Treeherder_view that requirements must be passed before getting to default treeherder
Assignee | ||
Comment 8•9 years ago
|
||
This patch adds Tier-2 flag on Treeherder
Attachment #8693514 -
Attachment is obsolete: true
Comment 9•9 years ago
|
||
Great! This looks good to me.
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8697008 [details] [diff] [review] [Tier-2] on treeherder Build is ok on try : https://treeherder.mozilla.org/#/jobs?repo=try&revision=381c03dc1c17
Attachment #8697008 -
Flags: review?(garndt)
Comment 11•9 years ago
|
||
Comment on attachment 8697008 [details] [diff] [review] [Tier-2] on treeherder Review of attachment 8697008 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me.
Attachment #8697008 -
Flags: review?(garndt) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 12•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/49efc3161093
Keywords: checkin-needed
Comment 13•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/49efc3161093
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•