Closed Bug 1207770 Opened 4 years ago Closed 4 years ago

Add no ril device on TaskCluster

Categories

(Firefox Build System :: Task Configuration, task)

ARM
Gonk (Firefox OS)
task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sousmangoosta, Assigned: sousmangoosta)

Details

(Whiteboard: [b2g-build-support])

Attachments

(1 file, 2 obsolete files)

We don't have a NO RIL TaskCluster image builded on try and other branches.
Can be source of bug on tablet builds where used of disable-b2g-ril.
Comment on attachment 8665089 [details] [diff] [review]
Use aries existant image with an env variables to simulate no ril device

Review of attachment 8665089 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like this is orange on TH.  Also, we should ask the sheriffs if this should be reporting to TH production.  I'm not sure what visibility should be set for a job like this.  Also, this has the same symbol as the regular build, so we might want to make it unique so there aren't more than one 'B' symbol.

Thanks for working on this!
Attachment #8665089 - Flags: review?(garndt) → review-
It should be orange until Bug 1207266 be landed.
Will try do better tomorrow for the symbol.
The try with additionnaly the patch of Bug 1207266 looks good : https://treeherder.mozilla.org/#/jobs?repo=try&revision=2613cebacfc8
Component: General → Task Configuration
Whiteboard: [tc-build-support]
Whiteboard: [tc-build-support] → [b2g-build-support]
(In reply to Greg Arndt [:garndt] from comment #3)
> Comment on attachment 8665089 [details] [diff] [review]
> Use aries existant image with an env variables to simulate no ril device
> 
> Review of attachment 8665089 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks like this is orange on TH.  Also, we should ask the sheriffs if this
> should be reporting to TH production.  I'm not sure what visibility should
> be set for a job like this.  Also, this has the same symbol as the regular
> build, so we might want to make it unique so there aren't more than one 'B'
> symbol.
> 
> Thanks for working on this!

Hi Roland, we have visibility requirements here https://wiki.mozilla.org/Sheriffing/Job_Visibility_Policy#Requirements_for_jobs_shown_in_the_default_Treeherder_view

that requirements must be passed before getting to default treeherder
This patch adds Tier-2 flag on Treeherder
Attachment #8693514 - Attachment is obsolete: true
Great! This looks good to me.
Comment on attachment 8697008 [details] [diff] [review]
[Tier-2] on treeherder

Review of attachment 8697008 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8697008 - Flags: review?(garndt) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/49efc3161093
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.