Closed Bug 1207793 Opened 8 years ago Closed 8 years ago

Fix unified bustage in wake of 1205054

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file)

fix_taggedproto_unified_bustage-v0.diff
1.70 KB, patch
jolesen
: review+
Details | Diff | Splinter Review 
I did not check for unified bustage before checking in the TaggedPointer split. This fixes it locally.
Attachment #8665106 - Flags: review?(jolesen)
Summary: Fix unfied bustage in wake of 1205054 → Fix unified bustage in wake of 1205054
Comment on attachment 8665106 [details] [diff] [review]
fix_taggedproto_unified_bustage-v0.diff

Review of attachment 8665106 [details] [diff] [review]:
-----------------------------------------------------------------

Was this fixed by bug 1207236 already?
Attachment #8665106 - Flags: review?(jolesen)
See Also: → 1207236
Comment on attachment 8665106 [details] [diff] [review]
fix_taggedproto_unified_bustage-v0.diff

The patch that got checked in in that bug appears to be different, gcc-specific brain-damage. It wouldn't solve the missing type issues that one gets when compiling non-unified.
Attachment #8665106 - Flags: review?(jolesen)
Comment on attachment 8665106 [details] [diff] [review]
fix_taggedproto_unified_bustage-v0.diff

Review of attachment 8665106 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks!
Attachment #8665106 - Flags: review?(jolesen) → review+
https://hg.mozilla.org/mozilla-central/rev/476f3cbb200b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.