1207850 - FetchBody::ContinueConsumeBody called twice

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Cătălin Badea (:catalinb)]

If the service worker is shutting down we run into a wierd case where we try to cancel the pump twice.

https://pastebin.mozilla.org/8847298

Comment 1

[Cătălin Badea (:catalinb)]

Attachment: Temporary fix for canceling the pump used by FetchBody. r?nsm

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8665187 [details] [diff] [review]
Temporary fix for canceling the pump used by FetchBody.  r?nsm

Review of attachment 8665187 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/fetch/Fetch.cpp
@@ +1142,5 @@
>  
>    bool Notify(JSContext* aCx, workers::Status aStatus) override
>    {
>      MOZ_ASSERT(aStatus > workers::Running);
> +    if (!mWasNotified) {

Could you also change this to aStatus > Canceling?
Ideally this should never be called twice since the call to ContinueConsumeBody should remove the feature, but I can see how having that blocking runnable in ContinueConsumeBody may lead to this being called twice.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/026a924b9228

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for android m12 failures: https://hg.mozilla.org/integration/mozilla-inbound/rev/85b9ecca55e5
https://treeherder.mozilla.org/logviewer.html#?job_id=14986157&repo=mozilla-inbound

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00d99c936b39

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/00d99c936b39