Closed Bug 1207934 Opened 4 years ago Closed 4 years ago

Caret does not show if the appearance is changing from Normal -> NormalNotShown -> Normal

Categories

(Core :: DOM: Selection, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Steps to reproduce:
1. Typing 10 'a's, a space 10 'b's on rocketbar. It's essential that those 'b's are long enough to make the input scroll.
2. Long press on 'b's
3. Long press on 'a's
4. Long press on 'b's again

Actual result:
The left caret is missing.

Expected result:
Both carets should show.
QA Contact: tlin
We cannot write this marionette test case until bug 1209841 is landed
Assignee: nobody → tlin
Depends on: 1209841
QA Contact: tlin
Bug 1207934 - Reset mImaginaryCaretRect if it is out of scrollport. r=roc
Attachment #8668985 - Flags: review?(roc)
Bug 1207934 - Fix word_location(). r=automatedtester

word_location() did not work if there are multiple spaces between words.
We split by \S+ which is non-spaces, so tokens[0] is an space token.
Test cases are added to ensure the correctness.
Attachment #8668986 - Flags: review?(dburns)
Bug 1207934 - Add marionette test for appearance changing. r=automatedtester

Test the second carets can still be dragging after its appearance
changing from Normal to NormalNotShown then back to Normal again. This
test is only for AccessibleCaret, not for SelectionCarets.
Attachment #8668987 - Flags: review?(dburns)
No longer blocks: 1210341
Comment on attachment 8668985 [details]
MozReview Request: Bug 1207934 - Reset mImaginaryCaretRect if it is out of scrollport. r=roc

https://reviewboard.mozilla.org/r/21095/#review19099
Attachment #8668985 - Flags: review?(roc) → review+
Comment on attachment 8668986 [details]
MozReview Request: Bug 1207934 - Fix word_location(). r=automatedtester

https://reviewboard.mozilla.org/r/21097/#review19199
Attachment #8668986 - Flags: review?(dburns) → review+
Comment on attachment 8668987 [details]
MozReview Request: Bug 1207934 - Add marionette test for appearance changing. r=automatedtester

https://reviewboard.mozilla.org/r/21099/#review19201
Attachment #8668987 - Flags: review?(dburns) → review+
https://reviewboard.mozilla.org/r/21099/#review19205

::: layout/base/tests/marionette/test_selectioncarets.py:731
(Diff revision 1)
> +        self.assertEqual(words[0][0], sel.selected_content)

To fix the try fails, I'll strip() sel.selected_content like the other tests since the spaces after the word will be selected on Windows.
Instead of adding strip() as described in comment 8, make this bug depends on bug 1212186 which disabled 'layout.word_select.eat_space_to_next_word' once and for all.

Try: 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ddc98b5f2db
Depends on: 1212186
You need to log in before you can comment on or make changes to this bug.