120799 - ok cancel buttons on subscribe dialog reversed

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[andreww]

it should be 
cancel ok
not 
ok cancel

Comment 1

[andreww]

I'm fixing this. f

Comment 2

[Håkan Waara]

You should convert this window to be a <dialog/> if it isn't already, and use
<okCancelButtons>. That will make us obey the platform the user is on.

Comment 3

[(not reading, please use [e-mail] instead)]

it's already a dialog.  see 
http://lxr.mozilla.org/mozilla/source/mailnews/base/resources/content/subscribe.
xul

Comment 4

[Håkan Waara]

Attachment: Fix

I had most of this in my tree already ...

Comment 5

[Håkan Waara]

BTW, the only relevant part is the patch to subscribe.xul ... all the changes 
to subscribe.js are just to remove dead out-commented dump()s.

Comment 6

[andreww]

Hmm - I'm at an impasse here because 
1) I need to explicitly define the buttons , so that they dont show up at the 
absolute bottom of the dialog (which they would by default) and
2) macs use cancel ok and pc's use ok cancel - so defining them explicitly 
doesnt seem to be an  option either because they will show up wrong on 
either pc or mac....

Comment 7

[andreww]

adding Jen.  

Jen - the issue here is this - if we fix this ok cancel thing it breaks having 
the status bar on the bottom again. Is that ok with you?

The reason is that to get the ok cancel in a place other than the default, 
you have to explicitly define  them in the xul. But the problem is that then 
the order of the buttons is wrong on mac or on pc depending on the order 
you set them.

so it appears that we cant have both - meaning ok cancel that morphs 
based on your platform and have status on the bottom (this is regardless 
of whether we wanted it on the bottom or not)

What is your thoughts on this Jen?

Comment 8

[andreww]

I think i have a way to fix this now...

Comment 9

[Lori Kaplan]

approving nomination. need to have correct order of buttons for different
platforms. 

Comment 10

[andreww]

fixing 62011 fixed this one also.

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED with:

Mac OS X 10.1.3 - 2002-03-22-08

Modern / Classic

Mac OS 9.2 - 2002-03-22-08

Modern / Classic

button order is 'Cancel' then 'OK'