Closed Bug 1207998 Opened 7 years ago Closed 7 years ago

[PBAP] Assertion failure: (mType) == (aType(unexpected type tag) at BluetoothTypes.h:248

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

Product:
Firefox OS Graveyard
Component:
Bluetooth
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.2r+, firefox45 fixed, b2g-v2.2r fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S11 (13Nov)
Project Flags:
blocking-b2g 2.2r+
Tracking Flags:
Tracking Status
firefox45 --- fixed
b2g-v2.2r --- fixed

People

(Reporter: shawnjohnjr, Assigned: ben.tian)

References

Details

Attachments

(2 files)

[final] Patch 1: Convert nsCString to nsString for BluetoothVCardListingEvent.mSearchValue, r=shuang
1.56 KB, patch
shawnjohnjr
: review+
Details | Diff | Splinter Review
[2.2r] Patch 1: Convert nsCString to nsString for BluetoothVCardListingEvent.mSearchValue, r=shuang
1.52 KB, patch
Details | Diff | Splinter Review 
Assertion failure: (mType) == (aType(unexpected type tag) 

https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/bluedroid/BluetoothPbapManager.cpp?case=true&from=BluetoothPbapManager.cpp#540

 nsCString text((char *) buf);
 AppendNamedValue(aValues, "searchText", text);

https://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/common/webapi/BluetoothAdapter.capp?from=BluetoothAdapter.cpp#1302
    } else if (name.EqualsLiteral("searchText")) {
      init.mSearchValue = value.get_nsString();
Blocks: 1199528
Comment on attachment 8681810 [details] [diff] [review]
[final] Patch 1: Convert nsCString to nsString for BluetoothVCardListingEvent.mSearchValue, r=shuang

Review of attachment 8681810 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8681810 - Flags: review?(shuang) → review+
Attachment #8681810 - Attachment description: Patch 1 (v1): Convert nsCString to nsString for BluetoothVCardListingEvent.mSearchValue → [final] Patch 1: Convert nsCString to nsString for BluetoothVCardListingEvent.mSearchValue, r=shuang
Set 2.2r blocker since the bug impacts on functionality of required bluetooth feature PBAP.
blocking-b2g: --- → 2.2r+
https://hg.mozilla.org/mozilla-central/rev/ea945385ee9d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
status-b2g-v2.2r: --- → affected
removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion
status-b2g-v2.5: fixed → ---
You need to log in before you can comment on or make changes to this bug.