12080 - [DOGFOOD] reply should put focus into message body, with cursor above the message, with "<sender> wrote:" between cursor and quoted message.

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

For M10 dogfood, we need this functionality:

when we hit reply, we need:
	the focus to be in message body
	the cursor to be in the message body
	"<sender> wrote:" should be above and the quoted message body. (where <sender
is the sender of the message you are replying to.)

as of my 8-18 build, none of that happens. (for html mail)
for plain text, the cursor is in the right place, but the focus is not in the
body and the "<sender> wrote:" is not there.

This basic reply functionality is important for the M-10 "get CPD to use
Messenger" milestone.

Comment 1

[Jean-Francois Ducarroz]

Focus to be in message body:
   Fixed

Cursor to be in the message body:
   The cursor is at the beggining, but you cannot type in it, bug 10681

"<sender> wrote:" should be above and the quoted message body. (where <sender
is the sender of the message you are replying to.:
   The label still is "Original message" but the quoted body now doesn't have
all the headers like before

Comment 2

[Phil Peterson]

Bulk move mail/news M10 bugs to M11

Comment 3

[Jean-Francois Ducarroz]

Reply now put "xxx wrote:" at the beginning. As all the points have been fixed,
I can close this bug report.

Comment 4

[laurel]

Using nov 9 commercial builds on all products:

NT 4.0:  upon launch of reply compose window, cursor briefly appears in the
body, but moves to address line.

Linux 6.0: cursor goes to address line.

Mac OS 8.5.1:  cursor goes to body (but it also does that for new msg)

Comment 5

[leger]

Not for PDT+, use the mouse. Putting on PDT- radar.

Comment 6

[Jean-Francois Ducarroz]

sfraser is adding a method to nsIEditorShell that will let me query for the nsIEditor (bug 18525). Then I will be able
to set the cursor either at the begining or at the end of the document (we use to have a pref for that in 4.5!).

Comment 7

[Jean-Francois Ducarroz]

I have a fix for it. I have also implemented the support of the 4.5 pref "mailnews.quote_on_top" that let the user
choose where to put the selection: 0=at the end, 1=on top, 2=select all.

I will checkin tomorrow after I get a code review.

Comment 8

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 9

[Jean-Francois Ducarroz]

because of bug 18723, don't set the pref mailnews.quote_on_top to 0 else you
will freeze!

Comment 10

[laurel]

OK using nov23-08 commercial builds on linux 6.0, mac OS 8.5.1 and NT 4.0
(verified NT on nbaca's machine since mine doesn't work).

Comment 11

[laurel]

OK for both HTML and Plain Text reply windows.