1208002 - Also optimize creation of RegExpMatch result for "str.match"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Hannes Verschore [:h4writer]]

In bug 879402 this was done for regular regexp matching. But I forgot to do this for string matching.

n = 0;
s = ('hello, world;'); let r = 'hello';
for (var i=0; i<1000000; i++) {
    n+= s.match(r).length;
}

print(n)

Takes 800ms, while with this patch 200ms.

Comment 1

[Hannes Verschore [:h4writer]]

Attachment: Patch

Comment 2

[Hannes Verschore [:h4writer]]

@arai: fyi, this will increase the old performance of "String.prototype.match(string)", without improving the performance of the selfhosted version. Your new code also removes this code, which isn't that bad. But I would like to make sure the selfhosted version is compared with the performance with this patch included. Still looking at potential improvements to get the selfhosted version at the same performance.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/54e7351f2a6a

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/54e7351f2a6a