Closed Bug 1208063 Opened 9 years ago Closed 9 years ago

Dialog to create new folder for bookmarks doesn't get focus for setting name/title of new folder

Categories

(Firefox :: Bookmarks & History, defect, P1)

41 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 44
Tracking Status
firefox41 --- wontfix
firefox42 + fixed
firefox43 + fixed
firefox44 + verified

People

(Reporter: aryx, Assigned: mak)

References

Details

(Keywords: regression, Whiteboard: [bugday-20160201] )

Attachments

(1 file)

Firefox 41.0, Beta 42.0a1, Aurora 20150922, Nightly 20150923 on Windows 8.1 64 bit
Not on 40.0.3

The dialog to create new folder for bookmarks doesn't get focus for setting its name.

Steps to reproduce:
1. Open bookmarks sidebar (Ctrl + B).
2. Open the folder 'Bookmarks Menu'
3. Right click somewhere in it and choose 'New folder'.
Actual result:
The bookmark dialog doesn't get focus.
For the name being applied to the wrong item, see bug 1208056 (which doesn't affect Nightly).
This also affects the bookmarks manage if the user right-clicks in the upper right pane for creating a new bookmark.
thank you for the range! Though I wonder if instead the problem is Bug 1199496 that collapsed all the fields by default and is in the same range.

This is annoying but far less blocking than the dataloss issue, I'll look into it hoping for an easy uplift.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Priority: -- → P1
I can confirm this bug - creating a new folder, changing "New Folder" by the name you wish is focused to the last folder shown at the bookmark panel!
I can also confirm this bug.
Blocks: 1199496
No longer blocks: 1194568
As expected, XUL focuses the first input control in the window, but since we collapsed all of them to avoid flickering, there's no control to focus. So we must basically reproduce that behavior manually.
I'm calling 41 a wontfix. while the other regression (bug 1206376) was actually causing dataloss, this is just an annoyance (a bad one) but it's harmless and workaroundable with a click. I don't think it's worth a chemspill.
Attachment #8670263 - Flags: review?(adw) → review+
[Tracking Requested - why for this release]: This is quite an annoyance for users trying to add bookmark folders.
Tracking for 44 because annoyance, see comment 10. (Annoyances have potential user impact, also it is a regression that affects the user :) )
https://hg.mozilla.org/mozilla-central/rev/b7060ab92ce5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment on attachment 8670263 [details] [diff] [review]
1208063.diff

Approval Request Comment
[Feature/regressing bug #]: bug 1199496
[User impact if declined]: When creating a new bookmark, but mostly a new folder, the title field doesn't get focus and the user has to explicily click on it to type the new folder title (this makes annoying something that usually is very quick)
[Describe test coverage new/current, TreeHerder]: automated test
[Risks and why]: low, only touching specific focus code
[String/UUID change made/needed]: none
Attachment #8670263 - Flags: approval-mozilla-beta?
Attachment #8670263 - Flags: approval-mozilla-aurora?
Comment on attachment 8670263 [details] [diff] [review]
1208063.diff

Regression fix, includes tests, ok for uplift to aurora.
Attachment #8670263 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Tracking since this is a recent regression.
Comment on attachment 8670263 [details] [diff] [review]
1208063.diff

Taking in beta to fix the recent regressions in bookmarks and we have a few more beta to fix potential regressions.
Should be in 42 beta 6.
Attachment #8670263 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Blocks: 924273
Has it also been fixed for creating new bookmarks? Right-click "New bookmark" has the same bug!
yes, the fix will be in Firefox 42.
QA Whiteboard: [good first verify]
Reproduced the bug in firefox nightly 44.0a1 (2015-09-24) with windows 10 (64 bit)

Verified as fixed with latest firefox release 43.0 (Build ID: 20151208200940)
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0

and latest firefox beta 44.0b9 (Build ID: 20160114165817)
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:44.0) Gecko/20100101 Firefox/44.0
Reproduced this bug with Firefox Nightly 44.0a1 (2015-09-24) (Build ID: 20150924030231) on Linux, 64 Bit with the instructions from comment 0.

This Bug is now verified as fixed on Latest Firefox Release 44.0 

Build ID: 20160126223146
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
QA Whiteboard: [good first verify] → [good first verify][bugday-20160120]
As this bug is verified on Windows (Comment 24) and Linux (Comment 25), I am marking this as verified !
Status: RESOLVED → VERIFIED
Whiteboard: [bugday-20160201]
You need to log in before you can comment on or make changes to this bug.