Closed
Bug 1208108
Opened 10 years ago
Closed 10 years ago
[Music][NGA] Clean-up before switching out Music app
Categories
(Firefox OS Graveyard :: Gaia::Music, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S8 (02Oct)
People
(Reporter: justindarc, Assigned: justindarc)
References
Details
Attachments
(1 file)
This is just a general purpose bug for doing some last-minute refinement and clean-up of the codebase before switching out the Music OGA app for Music NGA on master.
| Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jdarcangelo
Status: NEW → ASSIGNED
Depends on: 1207736
Priority: -- → P1
Target Milestone: --- → FxOS-S8 (02Oct)
Comment 1•10 years ago
|
||
This add the track indexes. But the album view still isn't sorted on that. :-/
Comment 2•10 years ago
|
||
And also it was said that if we only had one disc for the album we'd only show the track number instead of "disc.track".
Comment 3•10 years ago
|
||
Also we are supposed to get a plain "index" (not track index) in playlists. We don't with this change.
Comment 4•10 years ago
|
||
| Assignee | ||
Updated•10 years ago
|
Attachment #8666141 -
Flags: review?(squibblyflabbetydoo)
Comment 5•10 years ago
|
||
And now the tests pass (didn't even need to fix them again after that patch update).
Updated•10 years ago
|
Attachment #8666141 -
Flags: review?(squibblyflabbetydoo) → review+
| Assignee | ||
Comment 6•10 years ago
|
||
Landed on master:
https://github.com/mozilla-b2g/gaia/commit/97f526945720f81f39d91d983a8254fe53f14227
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•