1208157 - Add and use nsCycleCollector::IsIdle() predicate.

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Add and use nsCycleCollector::IsIdle() predicate. r=smaug

Comment 2

[Andrew McCreight [:mccr8]]

I noticed in the patch in bug 1168990 that it checks if the phase is idle outside of the CC. It seems like we should bundle that up into a predicate. It turns out we check that in a bunch of places so it would be good to have anyways.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Add and use nsCycleCollector::IsIdle() predicate.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Make the fields of nsCycleCollector private.

These are accidentally exposed by the NS_DECL.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=14e972868475

Comment 5

[Carsten Book [:Tomcat]]

Hi, this patch does not apply cleanly:

renamed 1208157 -> Bug-1208157-part-1---Add-and-use-nsCycleCollectorI.patch
applying Bug-1208157-part-1---Add-and-use-nsCycleCollectorI.patch
patching file xpcom/base/nsCycleCollector.cpp
Hunk #6 FAILED at 3843
1 out of 6 hunks FAILED -- saving rejects to file xpcom/base/nsCycleCollector.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh Bug-1208157-part-1---Add-and-use-nsCycleCollectorI.patch

can you take a look, thanks!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6d6f70df3a4
https://hg.mozilla.org/integration/mozilla-inbound/rev/9670ba04f47f

Comment 7

[Andrew McCreight [:mccr8]]

(In reply to Carsten Book [:Tomcat] from comment #5)
> can you take a look, thanks!

Sorry, I failed to realize there was some kind of dependency between a number of my patches. I've gone ahead and landed them myself. Thanks for your help.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d6d6f70df3a4
https://hg.mozilla.org/mozilla-central/rev/9670ba04f47f