Closed Bug 1208157 Opened 7 years ago Closed 7 years ago
Add and use ns
Cycle Collector::Is Idle() predicate .
No description provided.
I noticed in the patch in bug 1168990 that it checks if the phase is idle outside of the CC. It seems like we should bundle that up into a predicate. It turns out we check that in a bunch of places so it would be good to have anyways.
Attachment #8665544 - Attachment is obsolete: true
These are accidentally exposed by the NS_DECL. try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=14e972868475
Attachment #8665625 - Flags: review?(bugs)
Attachment #8665623 - Flags: review?(bugs) → review+
Attachment #8665625 - Flags: review?(bugs) → review+
Hi, this patch does not apply cleanly: renamed 1208157 -> Bug-1208157-part-1---Add-and-use-nsCycleCollectorI.patch applying Bug-1208157-part-1---Add-and-use-nsCycleCollectorI.patch patching file xpcom/base/nsCycleCollector.cpp Hunk #6 FAILED at 3843 1 out of 6 hunks FAILED -- saving rejects to file xpcom/base/nsCycleCollector.cpp.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and refresh Bug-1208157-part-1---Add-and-use-nsCycleCollectorI.patch can you take a look, thanks!
(In reply to Carsten Book [:Tomcat] from comment #5) > can you take a look, thanks! Sorry, I failed to realize there was some kind of dependency between a number of my patches. I've gone ahead and landed them myself. Thanks for your help.
You need to log in before you can comment on or make changes to this bug.