Closed Bug 1208184 Opened 4 years ago Closed 4 years ago

Make download of tooltool.py customizable via a config setting

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
Tracking Status
firefox44 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file, 1 obsolete file)

Similar to bug 724190 we should also drop a copy of tooltool.py into external tools. This might help a couple of projects which do not have this script available locally. As of now we only download it with developer mode turned on, but that's not always what you want on a production system.

Has anyone complains about that?
Let me take it. A patch will be ready in a moment.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attached patch tooltool v1 (obsolete) — Splinter Review
It adds the tooltool.py file to the external_tools sub folder, makes the patch available in the developer_config.py, and removes the code which existed to fetch the file. Not sure if anything else is necessary. Please let me know.

A try run is still active:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=72606a5ea6e3
Attachment #8665632 - Flags: review?(jlund)
Discussed this with Jordan on IRC and he is not that happy to have to maintain one more instance of it. So I had another idea to make it better configurable via a config setting. I think that is way better, and even only a 2-line patch.
Blocks: 1201588
Summary: Place a copy of tooltool.py into /external_tools → Make download of tooltool.py customizable via a config setting
Attached patch tooltool v2Splinter Review
Very simple patch which shouldn't break anything. So I don't think a try server build is necessary. But let me know if it is.
Attachment #8665632 - Attachment is obsolete: true
Attachment #8665632 - Flags: review?(jlund)
Attachment #8665645 - Flags: review?(jlund)
Attachment #8665645 - Flags: review?(jlund) → review+
https://hg.mozilla.org/mozilla-central/rev/98398ef6d987
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
jlund: if we don't place a copy of the tooltool script in Mozharness, we will then have to deploy that script to the TaskCluster docker images (or use the new flag).

IMHO, we should drop the "official" locations of those scripts ({git,hg,tool}tool.py) and make the Mozharness location the official place.
You need to log in before you can comment on or make changes to this bug.