1208184 - Make download of tooltool.py customizable via a config setting

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Similar to bug 724190 we should also drop a copy of tooltool.py into external tools. This might help a couple of projects which do not have this script available locally. As of now we only download it with developer mode turned on, but that's not always what you want on a production system.

Has anyone complains about that?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Let me take it. A patch will be ready in a moment.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: tooltool v1

It adds the tooltool.py file to the external_tools sub folder, makes the patch available in the developer_config.py, and removes the code which existed to fetch the file. Not sure if anything else is necessary. Please let me know.

A try run is still active:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=72606a5ea6e3

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Discussed this with Jordan on IRC and he is not that happy to have to maintain one more instance of it. So I had another idea to make it better configurable via a config setting. I think that is way better, and even only a 2-line patch.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: tooltool v2

Very simple patch which shouldn't break anything. So I don't think a try server build is necessary. But let me know if it is.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/98398ef6d987

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98398ef6d987

Comment 7

[Armen [:armenzg]]

jlund: if we don't place a copy of the tooltool script in Mozharness, we will then have to deploy that script to the TaskCluster docker images (or use the new flag).

IMHO, we should drop the "official" locations of those scripts ({git,hg,tool}tool.py) and make the Mozharness location the official place.