1208193 - Port Bug 1190462 [(Windows 10) Invisible tabs with "High Contrast White" system theme]

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

The actual implementation makes the tabs invisible with "High Contrast White" system theme (white tabs without border on white titlebar).

This bug is to port the FX changes to TB.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: HC-whiteFix.patch

This patch adapts the FX implementation.

In mailWindow1.css i removed also a (-moz-windows-default-theme) in one media query which was wrongly introduced with a -aero removal bug.

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 8665584 [details] [diff] [review]
HC-whiteFix.patch

Review of attachment 8665584 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/themes/windows/mail/tabmail.css
@@ +144,5 @@
> +
> +    .tab-background-middle[selected=true] {
> +      /* Setting background-size to "0 0" for the first
> +      background-image to remove the stroke. */
> +      background-size: 0 0, auto 100%, auto 100%;

I don't know this code well, but in Firefox, we use --tab-stroke-background-size to control the first background-size, so I'm not sure why this + --tab-stroke-background-size: 0; is needed.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: HC-whiteFix.patch

(In reply to Tim Nguyen [:ntim] from comment #2)
> Comment on attachment 8665584 [details] [diff] [review]
> HC-whiteFix.patch
> 
> Review of attachment 8665584 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mail/themes/windows/mail/tabmail.css
> @@ +144,5 @@
> > +
> > +    .tab-background-middle[selected=true] {
> > +      /* Setting background-size to "0 0" for the first
> > +      background-image to remove the stroke. */
> > +      background-size: 0 0, auto 100%, auto 100%;
> 
> I don't know this code well, but in Firefox, we use
> --tab-stroke-background-size to control the first background-size, so I'm
> not sure why this + --tab-stroke-background-size: 0; is needed.

Thank you for this hint. This block is redundant because above --tab-stroke-background-size: 0 0; is set.

Comment 4

[Richard Marti (:Paenglab)]

Thank you.

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/cd279df7194dba9a428b463c8f03584bf281d5f0
Bug 1208193 - Port Bug 1190462 [(Windows 10) Invisible tabs with "High Contrast White" system theme]. r=clokep