1208201 - Tidy up and simplify the setup functions in activeRoomStore

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

As part of bug 1154251, I need to adjust how some of the startup & setup is done.

Currently the two flows (one for desktop, one for standalone) in activeRoomStore that handle the initial setup are mixed in style, and do things in different places, and there's two different actions as a result (SetupRoomInfo, UpdateRoomInfo).

I'd like to make that a bit more consistent so that its easier to handle - make the flows the same for both and also that they end up with sending the UpdateRoomInfo action.

Comment 1

[Mark Banner (:standard8)]

Attachment: Simplify setup flows for standalone and desktop in Loop's activeRoomStore.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8665591 [details] [diff] [review]
Simplify setup flows for standalone and desktop in Loop's activeRoomStore.

Review of attachment 8665591 [details] [diff] [review]:
-----------------------------------------------------------------

This is more-or-less a patch like 'if it works and tests pass, it's worth it', because it's basically moving things around a bit.

LGTM.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/efd51878d60c

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/efd51878d60c