1208213 - Enabling custom hosting service breaks diffs

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Dan Minor [:dminor]]

When a hosting service is added to a repo, diffs break with an error stating that the patch failed to apply.

Comment 1

[Dan Minor [:dminor]]

Attachment: MozReview Request: mozreview: fix diff display when hostingservice is added to a repo (bug 1208213) r?mcote

mozreview: fix diff display when hostingservice is added to a repo (bug 1208213) r?mcote

Diff display was broken due to the truncation of the base_commit_id argument
to get_file in the HostingService base class so that we would always retrieve
the tip revision, causing patching to fail. This overrides get_file and
get_file_exists to pass in *kwargs to avoid truncation of arguments.

Comment 2

[Mark Côté [:mcote]]

Comment on attachment 8665943 [details]
MozReview Request: mozreview: fix diff display when hostingservice is added to a repo (bug 1208213) r?mcote

https://reviewboard.mozilla.org/r/20317/#review18445

Comment 3

[Dan Minor [:dminor]]

Thanks!

https://hg.mozilla.org/hgcustom/version-control-tools/rev/60c367cf9e4f

Comment 4

[Dan Minor [:dminor]]

I verified that this fixed the diff problem on dev.