Closed Bug 1208213 Opened 6 years ago Closed 6 years ago

Enabling custom hosting service breaks diffs

Categories

(MozReview Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dminor, Assigned: dminor)

Details

Attachments

(1 file)

When a hosting service is added to a repo, diffs break with an error stating that the patch failed to apply.
mozreview: fix diff display when hostingservice is added to a repo (bug 1208213) r?mcote

Diff display was broken due to the truncation of the base_commit_id argument
to get_file in the HostingService base class so that we would always retrieve
the tip revision, causing patching to fail. This overrides get_file and
get_file_exists to pass in *kwargs to avoid truncation of arguments.
Attachment #8665943 - Flags: review?(mcote)
Attachment #8665943 - Flags: review?(mcote) → review+
Comment on attachment 8665943 [details]
MozReview Request: mozreview: fix diff display when hostingservice is added to a repo (bug 1208213) r?mcote

https://reviewboard.mozilla.org/r/20317/#review18445
Thanks!

https://hg.mozilla.org/hgcustom/version-control-tools/rev/60c367cf9e4f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
I verified that this fixed the diff problem on dev.
Assignee: nobody → dminor
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.