Closed Bug 1208220 Opened 7 years ago Closed 7 years ago

no longer possible to run excerpt of a reftest manifest under a name other than reftest.list

Categories

(Testing :: Reftest, defect)

defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

(Keywords: regression)

Attachments

(1 file)

https://hg.mozilla.org/mozilla-central/rev/967ad761ec8c (last week) broke my ability to run a subset of a reftest manifest while debugging something.

For example, if I have a test in layout/reftests/bugs/ (a huge directory) that I broke, I'll grep the relevant test lines from reftest.list into that directory and run "./mach reftest layout/reftests/bugs/reftest-sub.list" on what I'm debugging.  (This also allows me to update my tree in various ways while doing this without having conflicts.)

This broke last week with the above changes, which makes it harder to debug reftest regressions.
Oh, and the error is:

Invalid manifest for suite reftest, file:///...layout/reftests/bugs/reftest-sub.list
Flags: needinfo?(james)
Keywords: regression
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Summary: no longer possible to run excerpt of a reftest manifest → no longer possible to run excerpt of a reftest manifest under a name other than reftest.list
Comment on attachment 8665609 [details] [diff] [review]
Remove test of manifest filename that breaks my workflow

Review of attachment 8665609 [details] [diff] [review]:
-----------------------------------------------------------------

OK. I think the point was to protect against weirdness if you try to specify manifests for different types of test at the same time, but if your workflow depends on nonstandard manifest names, this approach won't work.
Attachment #8665609 - Flags: review?(james) → review+
Flags: needinfo?(james)
https://hg.mozilla.org/mozilla-central/rev/87b4ca329e09
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.