1208220 - no longer possible to run excerpt of a reftest manifest under a name other than reftest.list

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/mozilla-central/rev/967ad761ec8c (last week) broke my ability to run a subset of a reftest manifest while debugging something.

For example, if I have a test in layout/reftests/bugs/ (a huge directory) that I broke, I'll grep the relevant test lines from reftest.list into that directory and run "./mach reftest layout/reftests/bugs/reftest-sub.list" on what I'm debugging.  (This also allows me to update my tree in various ways while doing this without having conflicts.)

This broke last week with the above changes, which makes it harder to debug reftest regressions.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oh, and the error is:

Invalid manifest for suite reftest, file:///...layout/reftests/bugs/reftest-sub.list

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Remove test of manifest filename that breaks my workflow

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8665609 [details] [diff] [review]
Remove test of manifest filename that breaks my workflow

Review of attachment 8665609 [details] [diff] [review]:
-----------------------------------------------------------------

OK. I think the point was to protect against weirdness if you try to specify manifests for different types of test at the same time, but if your workflow depends on nonstandard manifest names, this approach won't work.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87b4ca329e09

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/87b4ca329e09