Closed Bug 1208243 Opened 7 years ago Closed 7 years ago

Run ssl_gtest if it is built

Categories

(NSS :: Test, defect)

defect
Not set
normal

Tracking

(firefox44 affected)

RESOLVED FIXED
Tracking Status
firefox44 --- affected

People

(Reporter: mt, Assigned: mt)

Details

Attachments

(1 file, 1 obsolete file)

We can't run it always, but as long as it is built, we should run ssl_gtest as part of the full test suite.
Attached patch bug1208243.patch (obsolete) — Splinter Review
Assignee: nobody → martin.thomson
Status: NEW → ASSIGNED
Attachment #8665661 - Flags: review?(kaie)
Attachment #8665661 - Flags: review?(ekr)
Attached patch bug1208243.patchSplinter Review
Oops, forgot to add it to the list of tests.
Attachment #8665661 - Attachment is obsolete: true
Attachment #8665661 - Flags: review?(kaie)
Attachment #8665661 - Flags: review?(ekr)
Attachment #8665667 - Flags: review?(kaie)
Attachment #8665667 - Flags: review?(ekr)
Comment on attachment 8665667 [details] [diff] [review]
bug1208243.patch

Review of attachment 8665667 [details] [diff] [review]:
-----------------------------------------------------------------

::: external_tests/README
@@ +10,4 @@
>  
> +They can be run standalone or under a debugger by invoking the ssl_gtest
> +executable with a ``-d'' option pointing to the directory created by either
> +of the above options.  You can find that in

Something seems to be missing here.

::: tests/ssl_gtests/ssl_gtests.sh
@@ +52,5 @@
> +n
> +
> +n
> +CERTSCRIPT
> +  html_msg $? 0 "create ssl_gtest client certificate"

This probably needs ECDSA.

@@ +64,5 @@
> +n
> +
> +n
> +CERTSCRIPT
> +  html_msg $? 0 "create ssl_gtest ECDSA certificate"

Something seems screwy here.
Attachment #8665667 - Flags: review?(ekr)
(In reply to Eric Rescorla (:ekr) from comment #3)
> ::: external_tests/README
> @@ +10,4 @@
> >  
> > +They can be run standalone or under a debugger by invoking the ssl_gtest
> > +executable with a ``-d'' option pointing to the directory created by either
> > +of the above options.  You can find that in
> 
> Something seems to be missing here.

It's on the next line.  (It didn't fit on the line.)
 
> ::: tests/ssl_gtests/ssl_gtests.sh
> > +CERTSCRIPT
> > +  html_msg $? 0 "create ssl_gtest ECDSA certificate"
> 
> Something seems screwy here.

The html_msg lines happen after the call to certutil.  They have to because they check $?
Attachment #8665667 - Flags: review?(ekr)
Comment on attachment 8665667 [details] [diff] [review]
bug1208243.patch

Review of attachment 8665667 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8665667 - Flags: review?(ekr) → review+
https://hg.mozilla.org/projects/nss/rev/61aa0537da02

kaie, this will do nothing until you configure the builders to actually build the tests.  Can you identify one or two builders that have a modern-enough version of C++ (c++11) and set `NSS_BUILD_GTESTS=1` in the environment on those builders?
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(kaie)
Resolution: --- → FIXED
I've configured a new slave builder that uses Fedora 22 with gcc 5.1.1

It's the builder that has cpp11 in its name on test.nss-crypto.org
Flags: needinfo?(kaie)
Comment on attachment 8665667 [details] [diff] [review]
bug1208243.patch

seems to work on the new builder:

ssl_gtest.sh: #5257: create ssl_gtest database  - PASSED
ssl_gtest.sh: #5258: create ssl_gtest server certificate  - PASSED
ssl_gtest.sh: #5259: create ssl_gtest client certificate  - PASSED
ssl_gtest.sh: #5260: create ssl_gtest ECDSA certificate  - PASSED
ssl_gtest.sh: #5261: ssl_gtest run successfully  - PASSED
Attachment #8665667 - Flags: review?(kaie) → review+
Awesome, thanks Kai.
You need to log in before you can comment on or make changes to this bug.