1208243 - Run ssl_gtest if it is built

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Martin Thomson [:mt:]]

We can't run it always, but as long as it is built, we should run ssl_gtest as part of the full test suite.

Comment 1

[Martin Thomson [:mt:]]

Attachment: bug1208243.patch

Comment 2

[Martin Thomson [:mt:]]

Attachment: bug1208243.patch

Oops, forgot to add it to the list of tests.

Comment 3

[Eric Rescorla (:ekr)]

Comment on attachment 8665667 [details] [diff] [review]
bug1208243.patch

Review of attachment 8665667 [details] [diff] [review]:
-----------------------------------------------------------------

::: external_tests/README
@@ +10,4 @@
>  
> +They can be run standalone or under a debugger by invoking the ssl_gtest
> +executable with a ``-d'' option pointing to the directory created by either
> +of the above options.  You can find that in

Something seems to be missing here.

::: tests/ssl_gtests/ssl_gtests.sh
@@ +52,5 @@
> +n
> +
> +n
> +CERTSCRIPT
> +  html_msg $? 0 "create ssl_gtest client certificate"

This probably needs ECDSA.

@@ +64,5 @@
> +n
> +
> +n
> +CERTSCRIPT
> +  html_msg $? 0 "create ssl_gtest ECDSA certificate"

Something seems screwy here.

Comment 4

[Martin Thomson [:mt:]]

(In reply to Eric Rescorla (:ekr) from comment #3)
> ::: external_tests/README
> @@ +10,4 @@
> >  
> > +They can be run standalone or under a debugger by invoking the ssl_gtest
> > +executable with a ``-d'' option pointing to the directory created by either
> > +of the above options.  You can find that in
> 
> Something seems to be missing here.

It's on the next line.  (It didn't fit on the line.)
 
> ::: tests/ssl_gtests/ssl_gtests.sh
> > +CERTSCRIPT
> > +  html_msg $? 0 "create ssl_gtest ECDSA certificate"
> 
> Something seems screwy here.

The html_msg lines happen after the call to certutil.  They have to because they check $?

Comment 5

[Eric Rescorla (:ekr)]

Comment on attachment 8665667 [details] [diff] [review]
bug1208243.patch

Review of attachment 8665667 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 6

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/61aa0537da02

kaie, this will do nothing until you configure the builders to actually build the tests.  Can you identify one or two builders that have a modern-enough version of C++ (c++11) and set `NSS_BUILD_GTESTS=1` in the environment on those builders?

Comment 7

[Kai Engert (:KaiE:)]

I've configured a new slave builder that uses Fedora 22 with gcc 5.1.1

It's the builder that has cpp11 in its name on test.nss-crypto.org

Comment 8

[Kai Engert (:KaiE:)]

Comment on attachment 8665667 [details] [diff] [review]
bug1208243.patch

seems to work on the new builder:

ssl_gtest.sh: #5257: create ssl_gtest database  - PASSED
ssl_gtest.sh: #5258: create ssl_gtest server certificate  - PASSED
ssl_gtest.sh: #5259: create ssl_gtest client certificate  - PASSED
ssl_gtest.sh: #5260: create ssl_gtest ECDSA certificate  - PASSED
ssl_gtest.sh: #5261: ssl_gtest run successfully  - PASSED

Comment 9

[Martin Thomson [:mt:]]

Awesome, thanks Kai.