Closed
Bug 1208243
Opened 9 years ago
Closed 9 years ago
Run ssl_gtest if it is built
Categories
(NSS :: Test, defect)
NSS
Test
Tracking
(firefox44 affected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox44 | --- | affected |
People
(Reporter: mt, Assigned: mt)
Details
Attachments
(1 file, 1 obsolete file)
11.10 KB,
patch
|
KaiE
:
review+
ekr
:
review+
|
Details | Diff | Splinter Review |
We can't run it always, but as long as it is built, we should run ssl_gtest as part of the full test suite.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → martin.thomson
Status: NEW → ASSIGNED
Attachment #8665661 -
Flags: review?(kaie)
Attachment #8665661 -
Flags: review?(ekr)
Assignee | ||
Comment 2•9 years ago
|
||
Oops, forgot to add it to the list of tests.
Attachment #8665661 -
Attachment is obsolete: true
Attachment #8665661 -
Flags: review?(kaie)
Attachment #8665661 -
Flags: review?(ekr)
Attachment #8665667 -
Flags: review?(kaie)
Attachment #8665667 -
Flags: review?(ekr)
Comment 3•9 years ago
|
||
Comment on attachment 8665667 [details] [diff] [review]
bug1208243.patch
Review of attachment 8665667 [details] [diff] [review]:
-----------------------------------------------------------------
::: external_tests/README
@@ +10,4 @@
>
> +They can be run standalone or under a debugger by invoking the ssl_gtest
> +executable with a ``-d'' option pointing to the directory created by either
> +of the above options. You can find that in
Something seems to be missing here.
::: tests/ssl_gtests/ssl_gtests.sh
@@ +52,5 @@
> +n
> +
> +n
> +CERTSCRIPT
> + html_msg $? 0 "create ssl_gtest client certificate"
This probably needs ECDSA.
@@ +64,5 @@
> +n
> +
> +n
> +CERTSCRIPT
> + html_msg $? 0 "create ssl_gtest ECDSA certificate"
Something seems screwy here.
Attachment #8665667 -
Flags: review?(ekr)
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Eric Rescorla (:ekr) from comment #3)
> ::: external_tests/README
> @@ +10,4 @@
> >
> > +They can be run standalone or under a debugger by invoking the ssl_gtest
> > +executable with a ``-d'' option pointing to the directory created by either
> > +of the above options. You can find that in
>
> Something seems to be missing here.
It's on the next line. (It didn't fit on the line.)
> ::: tests/ssl_gtests/ssl_gtests.sh
> > +CERTSCRIPT
> > + html_msg $? 0 "create ssl_gtest ECDSA certificate"
>
> Something seems screwy here.
The html_msg lines happen after the call to certutil. They have to because they check $?
Assignee | ||
Updated•9 years ago
|
Attachment #8665667 -
Flags: review?(ekr)
Comment 5•9 years ago
|
||
Comment on attachment 8665667 [details] [diff] [review]
bug1208243.patch
Review of attachment 8665667 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8665667 -
Flags: review?(ekr) → review+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/projects/nss/rev/61aa0537da02
kaie, this will do nothing until you configure the builders to actually build the tests. Can you identify one or two builders that have a modern-enough version of C++ (c++11) and set `NSS_BUILD_GTESTS=1` in the environment on those builders?
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(kaie)
Resolution: --- → FIXED
Comment 7•9 years ago
|
||
I've configured a new slave builder that uses Fedora 22 with gcc 5.1.1
It's the builder that has cpp11 in its name on test.nss-crypto.org
Flags: needinfo?(kaie)
Comment 8•9 years ago
|
||
Comment on attachment 8665667 [details] [diff] [review]
bug1208243.patch
seems to work on the new builder:
ssl_gtest.sh: #5257: create ssl_gtest database - PASSED
ssl_gtest.sh: #5258: create ssl_gtest server certificate - PASSED
ssl_gtest.sh: #5259: create ssl_gtest client certificate - PASSED
ssl_gtest.sh: #5260: create ssl_gtest ECDSA certificate - PASSED
ssl_gtest.sh: #5261: ssl_gtest run successfully - PASSED
Attachment #8665667 -
Flags: review?(kaie) → review+
Assignee | ||
Comment 9•9 years ago
|
||
Awesome, thanks Kai.
You need to log in
before you can comment on or make changes to this bug.
Description
•