ICE Triggered Checks retransmit instead of starting new transactions

RESOLVED DUPLICATE of bug 1006809

Status

()

Core
WebRTC: Networking
P1
normal
Rank:
15
RESOLVED DUPLICATE of bug 1006809
3 years ago
3 years ago

People

(Reporter: drno, Assigned: drno)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(firefox44 affected)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
According to https://tools.ietf.org/html/rfc5245#section-7.2.1.4 bullet point 1.2 we are suppose to cancel ongoing STUN transactions and start a new one.

It looks like we are canceling the ongoing STUN transaction here https://dxr.mozilla.org/mozilla-central/source/media/mtransport/third_party/nICEr/src/stun/stun_client_ctx.c?offset=1000#284

But on the wire the new binding request has the same transaction ID as the previous.
(Assignee)

Updated

3 years ago
Blocks: 1176407

Updated

3 years ago
See Also: → bug 1006809

Updated

3 years ago
backlog: --- → webrtc/webaudio+
Rank: 15
Priority: -- → P1
(Assignee)

Comment 1

3 years ago
Created attachment 8672837 [details]
MozReview Request: Bug 1208254: (re)start a new ICE binding request trnasaction for triggered checks

Bug 1208254: (re)start a new ICE binding request trnasaction for triggered checks
Attachment #8672837 - Flags: review?(docfaraday)
(Assignee)

Comment 2

3 years ago
FYI without this patch we fail to connect to Cisco Spark, because the calls to nr_stun_client_force_retransmit() counts the retransmits towards the retransmission counters, which happens to be 1 for ICE TCP. This fixes that issue, because sending a new binding request does not count towards the transmission counter, which seems to be right thing any how.
I'm just not 100% sure if this change could lead to other bad side effects.
Assignee: nobody → drno
(Assignee)

Comment 3

3 years ago
Comment on attachment 8672837 [details]
MozReview Request: Bug 1208254: (re)start a new ICE binding request trnasaction for triggered checks

Apparently this is a bad idea/solution
Attachment #8672837 - Flags: review?(docfaraday)
(Assignee)

Comment 4

3 years ago
This basically got fixed through the code landed in bug 1006809.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1006809
(Assignee)

Updated

3 years ago
Duplicate of this bug: 1208276
You need to log in before you can comment on or make changes to this bug.