120831 - js_strncpy should inline-expand to memcpy

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brendan Eich [:brendan]]

What daniel said in http://bugzilla.mozilla.org/show_bug.cgi?id=117611#c24.

/be

Comment 1

[Brendan Eich [:brendan]]

Attachment: proposed fix

Easy, super-easy review -- please r= and sr=.

/be

Comment 2

[Daniel Bratell]

Comment on attachment 65666 [details] [diff] [review]
proposed fix

I've run with the patch (technically I wrote it :-) ) and haven't noticed
anything strange and it gives better performance. It's ok with me if you want
to count this as an r=bratell.

Comment 3

[Kenton Hanson (gone)]

Comment on attachment 65666 [details] [diff] [review]
proposed fix

r=khanson

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 65666 [details] [diff] [review]
proposed fix

Sorry, I didn't think it was non-obvious enough to worry about credit, but I
will give you that and sr= it.	With the r=khanson, we're set.	I'll get this
in when 0.9.9 opens.  Thanks for the patch, and the push to do it.

/be

Comment 5

[Daniel Bratell]

No worry. I just tried to lessen the number of other people needed to review it
by one.

Comment 6

[Brendan Eich [:brendan]]

Fix is in.

/be

Comment 7

[Phil Schwartau]

Marking Verified -