Closed Bug 1208376 Opened 4 years ago Closed 4 years ago

Implement the preference to disable v2 data upload in Firefox 42+

Categories

(Toolkit :: Telemetry, defect, P1)

defect
Points:
2

Tracking

()

VERIFIED FIXED
Tracking Status
firefox44 --- affected

People

(Reporter: gfritzsche, Assigned: Dexter)

References

Details

(Whiteboard: [unifiedTelemetry] [measurement:client])

Attachments

(3 files, 2 obsolete files)

It looks like we are at a go for shipping Unified Telemetry for 42.
Disabling HealthReport / v2 in 42 beta seems risky, so we are choosing the conservative route of just disabling data upload for v2.

This means we can land a minimal patch for a pref to specifically disable v2 upload.

Actually disabling v2 will happen, but should ride the trains properly to reduce risk of fallout.
Heads-up.
Flags: needinfo?(thuelbert)
Status: NEW → ASSIGNED
Attachment #8665934 - Flags: review?(gfritzsche)
Comment on attachment 8665934 [details] [diff] [review]
part 1 - Add a pref to disable v2 upload

Review of attachment 8665934 [details] [diff] [review]:
-----------------------------------------------------------------

Also add documentation for this pref to the Telemetry docs.

::: services/datareporting/policy.jsm
@@ +382,5 @@
> +   * Whether submission of data is allowed for v2.
> +   *
> +   * This is used to gently turn off data submission for FHR v2 in Firefox 42+.
> +   */
> +  get dataSubmissionEnabledv2() {

dataSubmissionEnabledV2()?
Attachment #8665934 - Flags: review?(gfritzsche) → review+
Comment on attachment 8665936 [details] [diff] [review]
part 2 - Flip the pref off (disables upload)

Review of attachment 8665936 [details] [diff] [review]:
-----------------------------------------------------------------

Lets hold this patch back for now.
Part 1 though could land after passing try (mochitest and xpcshell).
Attachment #8665936 - Flags: review?(gfritzsche) → review+
Keywords: leave-open
Blocks: 1209088
Alessio, will you still add documentation for this pref to the in-tree docs?
Flags: needinfo?(alessio.placitelli)
Comment on attachment 8665956 [details] [diff] [review]
part 1 - Add a pref to disable v2 upload - v2

Approval Request Comment
[Feature/regressing bug #]: Unified Telemetry
[User impact if declined]: No ability to disable only FHR upload per pref.
[Describe test coverage new/current, TreeHerder]: Automatic test coverage, basic manual coverage.
[Risks and why]: Low-risk: this only make a well-tested upload-switch depend on an additional pref to specifically only disable FHR upload.
[String/UUID change made/needed]: None.
Attachment #8665956 - Flags: approval-mozilla-beta?
Attachment #8665956 - Flags: approval-mozilla-aurora?
Attached patch part 3 - Update the docs. (obsolete) — Splinter Review
Sorry for the delay.
Flags: needinfo?(alessio.placitelli)
Attachment #8666749 - Flags: review?(gfritzsche)
Comment on attachment 8665956 [details] [diff] [review]
part 1 - Add a pref to disable v2 upload - v2

Taking it to polish this feature.
Attachment #8665956 - Flags: approval-mozilla-beta?
Attachment #8665956 - Flags: approval-mozilla-beta+
Attachment #8665956 - Flags: approval-mozilla-aurora?
Attachment #8665956 - Flags: approval-mozilla-aurora+
Comment on attachment 8666749 [details] [diff] [review]
part 3 - Update the docs.

Review of attachment 8666749 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/docs/preferences.rst
@@ +72,5 @@
>    This is the data submission master kill switch. If disabled, no policy is shown or upload takes place, ever.
>  
> +``datareporting.policy.dataSubmissionEnabled.v2``
> +
> +  If disabled, FHR v2 data will not be sent to Mozilla servers. Telemetry v4 data submission will not be affected.

Add: "This is like ``datareporting.policy.dataSubmissionEnabled``, but only affects FHR - Telemetry upload will not be disabled."
Attachment #8666749 - Flags: review?(gfritzsche) → review+
Attachment #8666749 - Attachment is obsolete: true
Attachment #8666755 - Flags: review+
Flags: qe-verify+
QA Contact: alexandra.lucinet
Flags: needinfo?(thuelbert)
Closing this bug, I've filed bug 1210815 to change the preference once a decision is taken.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: leave-open
Resolution: --- → FIXED
Summary: Disable v2 data upload in Firefox 42+ → Implement the preference to disable v2 data upload in Firefox 42+
Blocks: 1210815
Alexandra, I see this bug having a qe-verify+ but no verified flags nor a comment. I know it has been a while but was this verified?

We need to make sure no FHR v2 data is sent and v4 is still being sent with the pref datareporting.policy.dataSubmissionEnabled.v2 set to false.
Flags: needinfo?(alexandra.lucinet)
Verified fixed with 43.0b5 (Build ID: 20151119130424) and latest 45.0a1 (from 2015-11-19), across platforms [1].

[1] Mac OS X 10.10.4, Ubuntu 14.04 32-bit and Windows 8 32-bit
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(alexandra.lucinet)
You need to log in before you can comment on or make changes to this bug.