1208429 - Splitpanehistory: Clear Browsing data button should be implemented for each calendar option in particular

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, enhancement)

Description

[u549602]

Steps to reproduce:

1.User creates/already has browsing history
2.User opens Awesomescreen (while in landscape view) and taps on history tab
3.User taps on different calendar options
4.User taps on Clear history when in a specific calendar section  

Expected result:
Step 3:The clear browsing history (where available)is displayed only in the right section for the specific calendar tab
Step 4:The browsing history should be cleared specific for the period section in which the user was when the button was tapped 

Actual result:

Step 3: The clear browsing history (where available)is displayed on the whole bottom width of the screen
Step 4: When the user performs a clear history action when in a specific calendar period tab, the whole browsing history is cleared

Please note that it would be better if the user is allowed to clear only certain history (e.g. More than six months)and not all browsing history since it is organized by time periods

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

I wanted to file this bug too or at least start a discussion around this. I agree that currently a user will think that only the current visible history will be cleared. Especially we show/hide this button based on whether the current section contains history items.

Comment 2

[Richard Newman [:rnewman]]

Be careful.

A row in history right now is currently effectively a pair: (last visit, visit count).

That's a simplification of a sequence of (visit date, visit type, is local) tuples.

See Bug 1046709.

What do you think is supposed to happen when a user clicks "Clear history" in, say, the "Today" section?

1. Do we remove all visits created today, and leave the others, effectively forgetting your activity? It'll look like you visited twitter.com yesterday, but not today.

2. Do we delete all visits for items that have been visited today, removing them entirely from history? It'll look like you have never visited twitter.com.

My guess is that users will expect the former -- this is like desktop's "Clear Recent History" -- but:

* We cannot do this at all with the current history schema. Bug 1046709 will change this.
* We cannot sync partial visit deletions.



My suggestion would be to not offer Clear History inside the history list itself. Put it wherever you choose the time range, and make it clear that it clears all of your history.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Richard Newman [:rnewman] from comment #2)
> My suggestion would be to not offer Clear History inside the history list
> itself. Put it wherever you choose the time range, and make it clear that it
> clears all of your history.

Agreed. Especially with the sections being limited to 100 items (bug 1208472]): Clearing visible items vs. items that fall into the time range but are not visible.

Anthony: Thoughts?

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I think constraining this button to one container is the right path forward here. I think the right side makes the most sense since it's the stuff that will be cleared.

Vivek, can I also interest you in the UI clean up for this button? bug 1137333 :D

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

After IRC discussion with vivek, antlam and rnewman: Won't fix.

1) We would like to move it to the right section and only clear items of this section. As per comment:2 that's not possible and for now will never be.

2) If we keep clearing all history than having a button that spans the whole width of the screen is our preferred option.

Comment 6

[Vivek Balakrishnan[:vivek]]

Clearing NI