These files are currently residing in mozilla/include. They should be moved to somewhere under modules/plugin, since that's where they logically belong, and we'd like to get rid of mozilla/include at some point (see bug 38061).
How about moving them to mozilla/modules/plugin/base/public ?
Sounds good to me, I just meant "somewhere under the modules/plugin directory".
And they should probably dist'ed under some sensible place in include directory, not just its root. Is not this kind of task for the Build Config component?
Moving files in the cvs repo, yes. But since they are plugin files, we figured that you may want to have a say in where they end up.
I think they should go under modules/plugin/base/public and get distributed in dist/include/plugin.
I think there are a few other modules which use these as well.
It looks like it is included in a couple of embedding projects, as well as the MRJ plugin and Layout. Removing the link to layout would be as easy as breaking the nsPluginInstanceOwner code out into its own file and moving that into the plugin directory as well. This should be done anyway (I think I started doing it at some point... probably gone now, but the dependencies are already in place, so it's a painless move.) The MRJ Plugin is a special case, and can be treated as such. I'm not sure about the embedding stuff. It may be obsolete anyway... based on comments in another bug.
Created attachment 70439 [details] [diff] [review] export np*.h from modules/plugin/base/public & update users Dawn already copied the headers in the repo. This patch lets them be used from their new location. Once that works we can cvs rm the ones in include/ .
Comment on attachment 70439 [details] [diff] [review] export np*.h from modules/plugin/base/public & update users r=bryner
Patch has been checked in and files have been moved/removed.