move npapi.h, npupp.h to modules/plugin

VERIFIED FIXED

Status

()

Core
Plug-ins
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: Brian Ryner (not reading), Assigned: av (gone))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
These files are currently residing in mozilla/include.  They should be moved to
somewhere under modules/plugin, since that's where they logically belong, and
we'd like to get rid of mozilla/include at some point (see bug 38061).
(Reporter)

Updated

16 years ago
Blocks: 38061
Keywords: mozilla1.0
How about moving them to mozilla/modules/plugin/base/public ?
(Reporter)

Comment 2

16 years ago
Sounds good to me, I just meant "somewhere under the modules/plugin directory".
(Assignee)

Comment 3

16 years ago
And they should probably dist'ed under some sensible place in include directory, 
not just its root.

Is not this kind of task for the Build Config component?
Moving files in the cvs repo, yes.  But since they are plugin files, we figured
that you may want to have a say in where they end up.
(Assignee)

Comment 5

16 years ago
I think they should go under modules/plugin/base/public and get distributed in 
dist/include/plugin.

Comment 6

16 years ago
I think there are a few other modules which use these as well.

Comment 7

16 years ago
It looks like it is included in a couple of embedding projects, as well as the
MRJ plugin and Layout.

Removing the link to layout would be as easy as breaking the
nsPluginInstanceOwner code out into its own file and moving that into the plugin
directory as well. This should be done anyway (I think I started doing it at
some point... probably gone now, but the dependencies are already in place, so
it's a painless move.)

The MRJ Plugin is a special case, and can be treated as such.

I'm not sure about the embedding stuff. It may be obsolete anyway... based on
comments in another bug. 
Created attachment 70439 [details] [diff] [review]
export np*.h from modules/plugin/base/public & update users

Dawn already copied the headers in the repo.  This patch lets them be used from
their new location.  Once that works we can cvs rm the ones in include/ .
(Reporter)

Comment 9

16 years ago
Comment on attachment 70439 [details] [diff] [review]
export np*.h from modules/plugin/base/public & update users

r=bryner
Attachment #70439 - Flags: review+
Patch has been checked in and files have been moved/removed.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 11

16 years ago
v
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.