1208478 - JavaScript Error: "TypeError: timestamps[i] is undefined" {file: "app://system.gaiamobile.org/js/notification_screen.js" line: 377}

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[:gerard-majax]

Reproduced after I have updated my dogfooding build:

> 09-25 15:50:17.058   321   321 E GeckoConsole: [JavaScript Error: "TypeError: timestamps[i] is undefined" {file: "app://system.gaiamobile.org/js/notification_screen.js" line: 377}]
> 09-25 15:50:17.058   321   321 E GeckoConsole: [JavaScript Error: "TypeError: timestamps[i] is undefined" {file: "app://system.gaiamobile.org/js/notification_screen.js" line: 377}]
> 09-25 15:50:17.058   321   321 E GeckoConsole: [JavaScript Error: "TypeError: timestamps[i] is undefined" {file: "app://system.gaiamobile.org/js/notification_screen.js" line: 377}]
> 09-25 15:50:17.058   321   321 E GeckoConsole: [JavaScript Error: "TypeError: timestamps[i] is undefined" {file: "app://system.gaiamobile.org/js/notification_screen.js" line: 377}]
> 09-25 15:50:17.058   321   321 E GeckoConsole: [JavaScript Error: "TypeError: timestamps[i] is undefined" {file: "app://system.gaiamobile.org/js/notification_screen.js" line: 377}]
> 09-25 15:50:17.058   321   321 E GeckoConsole: [JavaScript Error: "TypeError: timestamps[i] is undefined" {file: "app://system.gaiamobile.org/js/notification_screen.js" line: 377}]
> 09-25 15:50:42.008   321   321 E GeckoConsole: [JavaScript Error: "TypeError: timestamps[i] is undefined" {file: "app://system.gaiamobile.org/js/notification_screen.js" line: 377}]
> 09-25 15:52:34.328   321   321 E GeckoConsole: [JavaScript Error: "TypeError: timestamps[i] is undefined" {file: "app://system.gaiamobile.org/js/notification_screen.js" line: 377}]
> 09-25 15:52:34.328   321   321 E GeckoConsole: [JavaScript Error: "TypeError: timestamps[i] is undefined" {file: "app://system.gaiamobile.org/js/notification_screen.js" line: 377}]

I don't know the consequences. Seems to be coming from bug 1203348.

Comment 1

[:gerard-majax]

https://github.com/mozilla-b2g/gaia/blob/405c72c8d613e8a08b7f598e347a4c6865e85990/apps/system/js/notification_screen.js#L377

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ugh, seems like my fault. Sorry!

Taking!

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

:gerard-majax - do you have any STRs, or does it happen instantly?

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1208478-spelling-in-timestamp-formatting > mozilla-b2g:master

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8666042 [details] [review]
[gaia] zbraniecki:1208478-spelling-in-timestamp-formatting > mozilla-b2g:master

Tim, can you give ma a quick review of that?

I made a mistake in my update timestamp formatting code and the `i` variable was not pointing to the correct timestamp in an array.

This code switches that away from live array and properly uses forEach and fat arrow functions instead.

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8666042 [details] [review]
[gaia] zbraniecki:1208478-spelling-in-timestamp-formatting > mozilla-b2g:master

Trying  different reviewer to offload Tim a bit :)

Comment 7

[Alberto Pastor [:albertopq]]

Comment on attachment 8666042 [details] [review]
[gaia] zbraniecki:1208478-spelling-in-timestamp-formatting > mozilla-b2g:master

r=me with the console.log removed and a unit test verifying this change. Thanks!

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/83133b63021fe53d43c415b0eb2e791bc26509bf