1208505 - Don't show crash recovery prompt if there are no tabs to recover

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Richard Newman [:rnewman]]

I just got an "Oops" prompt after upgrade. I had no non-home tabs open. Choosing to restore got me… about:home.

We shouldn't show a dialog in this case.

Comment 1

[Stephan Leroux [:sleroux]]

Resolved with: https://github.com/mozilla/firefox-ios/commit/df2f79df1fe9223cca909dc8c7154e8ce5653257

Comment 2

[Stephan Leroux [:sleroux]]

Oops wrong bug - meant to update https://bugzilla.mozilla.org/show_bug.cgi?id=1207593

Comment 3

[Stephan Leroux [:sleroux]]

Attachment: https://github.com/mozilla/firefox-ios/pull/1131

Comment 4

[Stephan Leroux [:sleroux]]

Updated patch with review comments + Array extension extraction. 

Also, I tested this by creating a ObjC class that has a single static method called 'crash' which @throws an NSException to trigger an uncaught exception. I added this to the addTab button call so the app would crash whenever I opened a new tab. I tried:

1. 5 Open tabs with various histories = shows prompt
2. 1 tab with history = shows prompt
3. 1 tab with no history = no prompt
4. 2 tabs with no history = no prompt

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 8670430 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1131

I'd love for the tiny change to BVC that actually fixes the bug to be in a separate commit, with the rest being "Pre" or "Part 0". It's hard to tell from the PR which part is important!

Comment 6

[Stephan Leroux [:sleroux]]

I've cleaned up the commits to be Pre: and Part with Part 1 containing the actual bug fix.

Comment 7

[Stephan Leroux [:sleroux]]

Merged