The feedback view has the incorrect blue for the Hello icon and button

RESOLVED FIXED in Firefox 43

Status

Hello (Loop)
Client
P2
normal
Rank:
21
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla44
Points:
1

Firefox Tracking Flags

(firefox43 fixed, firefox44 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
The feedback view and button are currently #4E92DF where they should be #00A9DC.
(Assignee)

Comment 1

2 years ago
Created attachment 8666045 [details] [diff] [review]
The feedback view has the incorrect blue for the Hello icon and button.

Adjusted the colour to match everything else, as per Sevaan over a vidyo call.
Attachment #8666045 - Flags: review?(mdeboer)
(Assignee)

Comment 2

2 years ago
Need this as part of bug 1208466.
Blocks: 1208466
Rank: 21
(Assignee)

Comment 3

2 years ago
Comment on attachment 8666045 [details] [diff] [review]
The feedback view has the incorrect blue for the Hello icon and button.

I'm sure I was going to put dmose down for this when I attached the patch earlier...
Attachment #8666045 - Flags: review?(mdeboer) → review?(dmose)
Comment on attachment 8666045 [details] [diff] [review]
The feedback view has the incorrect blue for the Hello icon and button.

Review of attachment 8666045 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose
Attachment #8666045 - Flags: review?(dmose) → review+
https://hg.mozilla.org/mozilla-central/rev/881864ab2ba4
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
(Assignee)

Comment 7

2 years ago
Created attachment 8669636 [details] [diff] [review]
Patch for aurora

Approval Request Comment
[Feature/regressing bug #]: Hello visual refresh
[User impact if declined]: Feedback view colours are inconsistent with the rest of Hello
[Describe test coverage new/current, TreeHerder]: N/A, css/image only
[Risks and why]: Low, css & svn change only
[String/UUID change made/needed]: None
Attachment #8669636 - Flags: approval-mozilla-aurora?
status-firefox43: --- → affected
Comment on attachment 8669636 [details] [diff] [review]
Patch for aurora

OK on m-c, seems fine to uplift to aurora
Attachment #8669636 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 9

2 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/32551122be1c
status-firefox43: affected → fixed

Updated

2 years ago
Iteration: 44.2 - Oct 19 → 44.1 - Oct 5
You need to log in before you can comment on or make changes to this bug.