1208553 - Convert gaia ui tests for music-nga app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[No-Jun Park [:njpark]]

The music-NGA app which is scheduled to replace the current Music app is internally in many ways different from the Music app.  Need a converted Music-NGA app methods to run sanity / MTBF test cases on it.

Comment 1

[No-Jun Park [:njpark]]

Turns out that we need the fix from bug 1194224, to avoid the shadown DOM issue.  According to Martijn, the new marionette with this fix has not been released yet.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:1208553 > mozilla-b2g:master

Comment 3

[No-Jun Park [:njpark]]

Comment on attachment 8671006 [details] [review]
[gaia] npark-mozilla:1208553 > mozilla-b2g:master

So this is my first attempt at converting music test cases.  All of them are running properly, and I have moved the oga test cases to music_oga folder.

One thing I decided to do was that for each music method, switching to iframe and shadow dom happens individually, and when a method is done, it returns the frame to the displayed_app.  I made no assumptions that previous methods have set the iframe and shadow DOM for the next one since that would cause a number of confusions, especially when there is a context change needed.

Also it would make things easier for converting imagecompare test cases to NGA since screen capture action switches frames every time.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8671006 [details] [review]
[gaia] npark-mozilla:1208553 > mozilla-b2g:master

That's a great start! Thank you for rewriting all of this.

You already answered to many of the questions and suggestions I had. We're likely need some more thoughts about shadow DOM, but taking into account the fact that we don't have any tests on this new app, I'd prefer to not bikeshed it and do it after the landing.

If you could you could put a link to the adhoc job before merging the patch, that'd be perfect.

Comment 5

[Martijn Wargers (dead)]

Comment on attachment 8671006 [details] [review]
[gaia] npark-mozilla:1208553 > mozilla-b2g:master

I started commenting and found a couple of issues, had some questions, etc, but in general, this looks good and I think it's better to get this checked in, so we start to have tests for this again, instead of keeping this stalled by adding review nits and comments.
We could file a follow-up on potential improvements for these files, what do you think?

So either way, I'm fine with you checking this in now. If you want a thorough review, then please re-ask review again.
I ran the tests and they run fine here.

Thanks for doing this No-Jun!

Comment 6

[No-Jun Park [:njpark]]

Adhoc run:
http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc.bitbar/278/

Comment 7

[No-Jun Park [:njpark]]

Looks like adhoc job is passing. jlorenzo, how does my subclass implementation on listview and sublistview look to you?

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8671006 [details] [review]
[gaia] npark-mozilla:1208553 > mozilla-b2g:master

That looks good and the adhoc job is promising :)

Comment 9

[No-Jun Park [:njpark]]

Merged:

https://github.com/mozilla-b2g/gaia/commit/9711ea4f0215a91ed465ebc8d9c915c0d4455676