Closed Bug 1208565 Opened 9 years ago Closed 8 years ago

No highlight for URL bar or tabs button

Categories

(Firefox for iOS :: Theme & Visual Design, defect)

Product:
Firefox for iOS
Component:
Theme & Visual Design
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: bnicholson, Assigned: bmunar, Mentored)

Details

(Whiteboard: [nicetohave])

Attachments

(1 file)

https://github.com/mozilla/firefox-ios/pull/1595
2 bytes, text/plain
bnicholson
: review+
tecgirl
: ui-review+
Details 
To give the user some visual feedback, it might be helpful to change the color of the URL bar/tabs button when they're clicked. I thought we used to do this; regression?
Under UX consideration.
Assignee: nobody → randersen
tracking-fxios: ? → 2.0+
Whiteboard: [nicetohave]
Yes, let's add the default highlight back to tab button. I can't even recall what we did for the URL bar. Did we highlight just the input grey?
Flags: needinfo?(dhenein)
I believe so... I don't remember specifying anything other than the default.
Flags: needinfo?(dhenein)
Assignee: randersen → bnicholson
I think it's safe to say this isn't a 2.0 blocker.
Assignee: bnicholson → nobody
Mentor: bnicholson
tracking-fxios: 2.0+ → +
Assignee: nobody → bmunar

        Attachment #8726397 -
        Flags: ui-review?(randersen)

        Attachment #8726397 -
        Flags: review?(bnicholson)

    
    

    
  
Comment on attachment 8726397 [details]
https://github.com/mozilla/firefox-ios/pull/1595

LGTM

Can we inverse the number and border color on tap?

    
  
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 8726397 [details]
https://github.com/mozilla/firefox-ios/pull/1595

On the right track, but I think we can clean this up a bit.

        Attachment #8726397 -
        Flags: review?(bnicholson) → feedback+

    
  
Flags: needinfo?(bnicholson)

    
  
Flags: needinfo?(bnicholson)

        Attachment #8726397 -
        Flags: feedback+ → review?(bnicholson)

    
    

    
  
Comment on attachment 8726397 [details]
https://github.com/mozilla/firefox-ios/pull/1595

Moar comments.

        Attachment #8726397 -
        Flags: review?(bnicholson) → feedback+

        Attachment #8726397 -
        Flags: ui-review?(randersen) → ui-review+

    
  

        Attachment #8726397 -
        Flags: feedback+ → feedback?

    
  

        Attachment #8726397 -
        Flags: feedback? → feedback?(bnicholson)

    
  

        Attachment #8726397 -
        Flags: feedback?(bnicholson) → review+

    
  
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.0

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: