No highlight for URL bar or tabs button

RESOLVED FIXED in 4.0

Status

()

Firefox for iOS
Theme & Visual Design
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: bnicholson, Assigned: bkmunar, Mentored)

Tracking

unspecified
All
iOS

Firefox Tracking Flags

(fxios+)

Details

(Whiteboard: [nicetohave])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
To give the user some visual feedback, it might be helpful to change the color of the URL bar/tabs button when they're clicked. I thought we used to do this; regression?
Under UX consideration.
Assignee: nobody → randersen
tracking-fxios: ? → 2.0+
Whiteboard: [nicetohave]
Yes, let's add the default highlight back to tab button. I can't even recall what we did for the URL bar. Did we highlight just the input grey?
Flags: needinfo?(dhenein)
I believe so... I don't remember specifying anything other than the default.
Flags: needinfo?(dhenein)
Assignee: randersen → bnicholson
(Reporter)

Comment 4

2 years ago
I think it's safe to say this isn't a 2.0 blocker.
Assignee: bnicholson → nobody
Mentor: bnicholson
tracking-fxios: 2.0+ → +
(Assignee)

Updated

2 years ago
Assignee: nobody → bmunar
(Assignee)

Comment 5

2 years ago
Created attachment 8726397 [details]
https://github.com/mozilla/firefox-ios/pull/1595
Attachment #8726397 - Flags: ui-review?(randersen)
Attachment #8726397 - Flags: review?(bnicholson)
Comment on attachment 8726397 [details]
https://github.com/mozilla/firefox-ios/pull/1595

LGTM

Can we inverse the number and border color on tap?
(Reporter)

Updated

2 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 7

2 years ago
Comment on attachment 8726397 [details]
https://github.com/mozilla/firefox-ios/pull/1595

On the right track, but I think we can clean this up a bit.
Attachment #8726397 - Flags: review?(bnicholson) → feedback+
(Assignee)

Updated

2 years ago
Flags: needinfo?(bnicholson)
(Reporter)

Updated

2 years ago
Flags: needinfo?(bnicholson)
Attachment #8726397 - Flags: feedback+ → review?(bnicholson)
(Reporter)

Comment 8

2 years ago
Comment on attachment 8726397 [details]
https://github.com/mozilla/firefox-ios/pull/1595

Moar comments.
Attachment #8726397 - Flags: review?(bnicholson) → feedback+
Attachment #8726397 - Flags: ui-review?(randersen) → ui-review+
(Assignee)

Updated

2 years ago
Attachment #8726397 - Flags: feedback+ → feedback?
(Assignee)

Updated

2 years ago
Attachment #8726397 - Flags: feedback? → feedback?(bnicholson)
(Reporter)

Updated

2 years ago
Attachment #8726397 - Flags: feedback?(bnicholson) → review+
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.0
You need to log in before you can comment on or make changes to this bug.