Closed Bug 1208576 Opened 5 years ago Closed 5 years ago

Build: appcompat-v7 should not depend on MOZ_NATIVE_DEVICES anymore

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

All
Android
defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

Attachments

(1 file)

In bug 1201206 we are going to use appcompat-v7 components independently from our chromecast implementation (MOZ_NATIVE_DEVICES). So we should always build with appcompat-v7, regardless of this flag.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Bug 1208576 - Build with appcompat-v7 regardless of MOZ_NATIVE_DEVICES flag. r?nalexander
Attachment #8666663 - Flags: review?(nalexander)
Comment on attachment 8666663 [details]
MozReview Request: Bug 1208576 - Build with appcompat-v7 regardless of MOZ_NATIVE_DEVICES flag. r?nalexander

https://reviewboard.mozilla.org/r/20593/#review18443

If it works for you, it works for me.

::: build/autoconf/android.m4:401
(Diff revision 1)
> +    MOZ_ANDROID_AAR(appcompat-v7, 22.2.1, android, com/android/support)

nit: let's move this up to keep alphabetical order.

::: mobile/android/gradle/base/build.gradle:73
(Diff revision 1)
>      compile 'com.android.support:support-v4:22.2.0'

Can you pin to 22.2.1 while you're here?  This is a mismatch that is not intentional.
Attachment #8666663 - Flags: review?(nalexander) → review+
https://hg.mozilla.org/mozilla-central/rev/6c6f1bce4ba5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 44 → mozilla44
You need to log in before you can comment on or make changes to this bug.