1208576 - Build: appcompat-v7 should not depend on MOZ_NATIVE_DEVICES anymore

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

In bug 1201206 we are going to use appcompat-v7 components independently from our chromecast implementation (MOZ_NATIVE_DEVICES). So we should always build with appcompat-v7, regardless of this flag.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

From:
https://dxr.mozilla.org/mozilla-central/source/build/autoconf/android.m4?offset=0#300

To:
https://dxr.mozilla.org/mozilla-central/source/build/autoconf/android.m4?offset=300#401

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Using appcompat without build changes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b42c451c8d88

With build patch applied:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ac68df0cc2b

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1208576 - Build with appcompat-v7 regardless of MOZ_NATIVE_DEVICES flag. r?nalexander

Bug 1208576 - Build with appcompat-v7 regardless of MOZ_NATIVE_DEVICES flag. r?nalexander

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8666663 [details]
MozReview Request: Bug 1208576 - Build with appcompat-v7 regardless of MOZ_NATIVE_DEVICES flag. r?nalexander

https://reviewboard.mozilla.org/r/20593/#review18443

If it works for you, it works for me.

::: build/autoconf/android.m4:401
(Diff revision 1)
> +    MOZ_ANDROID_AAR(appcompat-v7, 22.2.1, android, com/android/support)

nit: let's move this up to keep alphabetical order.

::: mobile/android/gradle/base/build.gradle:73
(Diff revision 1)
>      compile 'com.android.support:support-v4:22.2.0'

Can you pin to 22.2.1 while you're here?  This is a mismatch that is not intentional.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6c6f1bce4ba5

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6c6f1bce4ba5